Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutate the passed ZipFile object type instead of making a copy. #59

Merged
merged 4 commits into from
Sep 22, 2020

Conversation

jaraco
Copy link
Owner

@jaraco jaraco commented Sep 22, 2020

Prevents issues when both the local copy and the caller's copy attempt to close the same file handle.

Fixes bpo-40564 and fixes #57.

@jaraco jaraco merged commit b21a8dd into master Sep 22, 2020
@jaraco jaraco deleted the bugfix/bpo-40564-option-2 branch September 22, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of zipp.Path causes attempt to write after ZipFile is closed
1 participant