Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Email counts not working #67

Closed
thartl opened this issue Sep 11, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@thartl
Copy link
Contributor

commented Sep 11, 2018

Email counts were not incrementing for me and a couple small code edits made it work.
I thought I'd share in case this is a valid fix. I will fork and submit a pull request.

Plugin version - 1.2.0

Current Behavior

With the plugin set to use SharedCount.com as Count Source, email shares were not incrementing.

Possible Solution

In class-shared-counts-core.php:

  1. On Line 125, changed the comparison operator from === to !==
  2. On Line 127, changed post-increment ($count++) to pre-increment (++$count)

@jaredatch jaredatch closed this in 0677193 Apr 12, 2019

@jaredatch

This comment has been minimized.

Copy link
Owner

commented Apr 12, 2019

@thartl much appreciated :)

@thartl

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

My pleasure. Thank you for a great plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.