Join GitHub today
Fixes #64 - Better support for "limited" route parameters #65
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
@GothAck I'm currently looking at this patch, and considering merging it in.
In general, I like the fact that Express offers the ability to have RegExp-based routes. But, since Express routes are single level (no namespaces, no resource nesting, etc.), it's clear to reason about what the regex applies to. What's not clear, to me, is what happens when a RegExp is used in Locomotive on a resourceful or namespaced route. Match routes are clear, as long as they aren't nested.
What situations are you finding yourself needing this in? Moving this out of Namespace (and into match?) and some test coverage would ease my concerns. Holding off for now.