Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Merge pull request #13 from niftylettuce/master

Added note regarding Facebook's bug with window.location.hash for issue #12
  • Loading branch information...
commit a53354bf7c2006841ebe1b4ce094990828fb4c62 2 parents 69c5f18 + 86166d4
@jaredhanson authored
Showing with 6 additions and 2 deletions.
  1. +6 −2 README.md
View
8 README.md
@@ -49,13 +49,13 @@ application:
// this function will not be called.
});
- app.get('/auth/facebook/callback',
+ app.get('/auth/facebook/callback',
passport.authenticate('facebook', { failureRedirect: '/login' }),
function(req, res) {
// Successful authentication, redirect home.
res.redirect('/');
});
-
+
#### Extended Permissions
If you need extended permissions from the user, the permissions can be requested
@@ -73,6 +73,10 @@ checkins:
## Examples
+*NOTE*: There is a [current Facebook bug][1] that appends the hash `#_=_` to the callback URL's redirect. Please use [this fix][2] in the meantime.
+[1]: https://developers.facebook.com/bugs/196125357123225
+[2]: https://github.com/jaredhanson/passport-facebook/issues/12#issuecomment-5913711
+
For a complete, working example, refer to the [login example](https://github.com/jaredhanson/passport-facebook/tree/master/examples/login).
## Tests

2 comments on commit a53354b

@talamaska

this seems to be still a problem, the bug is not found, was it fixed at all, cause i'm still getting that hash in my callback url
Is there another bug reported?

@jaredhanson

The hash is never passed to the server so there is nothing that can be done from the server-side. This was merged simply to mention the issue in the README (since its a common question) and point people to the workaround. If you want to use it, you need to add it to your client-side code.

Please sign in to comment.
Something went wrong with that request. Please try again.