Add support for auth with Corporate GitHubs #5

Merged
merged 2 commits into from Apr 10, 2013

Conversation

Projects
None yet
2 participants
Contributor

rragan commented Feb 28, 2013

Minor changes needed to allow passport authorization with Corporate GitHubs plus the existing public GitHub already supported. Requires a new option (profileUrl) if you are using a corporate Github providing the URL for passport-github to use when doing the userProfile api call. For example, you might supply something like the following where corpDomain has the value for your corporate GitHub (e.g. github.mycorp.com)

"userProfileURL":"https://github.corpDomain/api/v3/user"

This is the only place that the api calling style differs for corporate GitHub deployments for the things passport-github is doing.

jaredhanson added a commit that referenced this pull request Apr 10, 2013

Merge pull request #5 from rragan/corpGitHub
Add support for auth with Corporate GitHubs

@jaredhanson jaredhanson merged commit d4d936f into jaredhanson:master Apr 10, 2013

1 check passed

default The Travis build passed
Details
Owner

jaredhanson commented Apr 10, 2013

Thanks! I've merged and published this as passport-github v0.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment