Avoid 'undefined undefined' displayName #7

merged 1 commit into from Feb 11, 2013


None yet
2 participants

lortabac commented Nov 13, 2012

When a provider does not provide the full name of the user, displayName is set to 'undefined undefined', which is annoying.

Added the condition to only set displayName if firstname and lastname parameters are set, so applications can handle empty names.

Avoid 'undefined undefined' displayName.
Only set profile.displayName if firstname and lastname parameters are set.

jaredhanson added a commit that referenced this pull request Feb 11, 2013

Merge pull request #7 from lortabac/master
Avoid 'undefined undefined' displayName

@jaredhanson jaredhanson merged commit 556ac28 into jaredhanson:master Feb 11, 2013

1 check passed

default The Travis build passed

jaredhanson commented Feb 11, 2013

Thanks! Merged and published to npm as passport-openid v0.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment