Skip to content
Browse files

Wrap error for informative message.

  • Loading branch information...
1 parent 6e20216 commit e804dd8d4cfab64267f435a557484e78669bff34 @jaredhanson committed
Showing with 6 additions and 2 deletions.
  1. +3 −2 lib/passport-rdio/strategy.js
  2. +3 −0 test/strategy-test.js
View
5 lib/passport-rdio/strategy.js
@@ -2,7 +2,8 @@
* Module dependencies.
*/
var util = require('util')
- , OAuthStrategy = require('passport-oauth').OAuthStrategy;
+ , OAuthStrategy = require('passport-oauth').OAuthStrategy
+ , InternalOAuthError = require('passport-oauth').InternalOAuthError;
/**
@@ -76,7 +77,7 @@ util.inherits(Strategy, OAuthStrategy);
*/
Strategy.prototype.userProfile = function(token, tokenSecret, params, done) {
this._oauth.post('http://api.rdio.com/1/', token, tokenSecret, { method: 'currentUser' }, function (err, body, res) {
- if (err) { return done(err); }
+ if (err) { return done(new InternalOAuthError('failed to fetch user profile', err)); }
try {
var json = JSON.parse(body);
View
3 test/strategy-test.js
@@ -99,6 +99,9 @@ vows.describe('RdioStrategy').addBatch({
'should error' : function(err, req) {
assert.isNotNull(err);
},
+ 'should wrap error in InternalOAuthError' : function(err, req) {
+ assert.equal(err.constructor.name, 'InternalOAuthError');
+ },
'should not load profile' : function(err, profile) {
assert.isUndefined(profile);
},

0 comments on commit e804dd8

Please sign in to comment.
Something went wrong with that request. Please try again.