Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document isAuthenticated #498

Open
cfjedimaster opened this issue Jun 24, 2016 · 2 comments
Open

Document isAuthenticated #498

cfjedimaster opened this issue Jun 24, 2016 · 2 comments

Comments

@cfjedimaster
Copy link

@cfjedimaster cfjedimaster commented Jun 24, 2016

Apparently Passport adds isAuthenticated (and isUnauthenticated) to the Request object, as mentioned in this SO post: http://stackoverflow.com/questions/14188834/documentation-for-ensureauthentication-isauthenticated-passports-functions/14301657#14301657

Is there any reason why this isn't documented?

@Tarabass
Copy link

@Tarabass Tarabass commented Jun 24, 2016

I think the user was not authenticated..

Maybe the examples in the documentation needs an update too:

http://passportjs.org/docs/authorize (last code block)

@JC3
Copy link

@JC3 JC3 commented Dec 9, 2016

Yeah it's a little ridiculous that this isn't documented, given that checking it is pretty much the entire ultimate goal of this library...

The consequence of this little mistake is a zillion tutorials that stop at the page authorization part, or goofie strategies like checking if random session fields are undefined.

It's sort of beyond me how Passport has gone on for so long with zero mention of this function on the page, in the readme, or in any other docs, given how important it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants