From 8684e7334b8a7a2bac66234e156568c012a5c6d6 Mon Sep 17 00:00:00 2001 From: DeVon Jackson <50152349+devo-wm@users.noreply.github.com> Date: Fri, 3 Feb 2023 11:38:40 +0000 Subject: [PATCH] validating domain without re-setting variable --- simple_acme_dns/__init__.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/simple_acme_dns/__init__.py b/simple_acme_dns/__init__.py index 024f1bc..5eae79f 100644 --- a/simple_acme_dns/__init__.py +++ b/simple_acme_dns/__init__.py @@ -620,10 +620,9 @@ def __validate_domains__(self) -> None: msg = "Domains must be rtype 'list'." raise errors.InvalidDomain(msg) for domain in self.domains: - if domain[:2] == "*.": - # If wildcard domain, strip of the wildcard to validate domain - domain = domain[2:] - if not validators.domain(domain): + # If wildcard domain, strip of the wildcard to validate domain + domain_to_validate = domain[2:] if domain[:2] == "*." else domain + if not validators.domain(domain_to_validate): msg = f"Invalid domain name '{domain}'. Domain name must adhere to RFC2181." raise errors.InvalidDomain(msg)