Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixes to allow building the module with Microsoft VC compiler #3

wants to merge 3 commits into


None yet
2 participants

MSVC is stupid and throws an error during build if you declare a variable anywhere but at the top of a function. Additionally, strncmp is not defined in the MSVC standard headers. To fix these two issues, I moved a couple of variable declarations to the top of their function, and threw in a quick macro so that if the user is compiling the source code from MSVC, it will use _strnicmp instead of strncmp. (Same thing)


jaredly commented Jul 21, 2013

Hey would you like to update this PR? Sorry I didn't get at it earlier; I was serving a mission in germany when you submitted this, but now I'm back in the real world.

Charles Grunwald (Juntalis) added some commits Jul 22, 2014

Sorry for getting back to you a year later on this, but I just now noticed your response. Anyways, I've gone ahead and updated the PR.

Also, sorry for the double commit. Didn't notice the formatting issue in parser.c until after the fact, and made my changes in the web interface. If you'd prefer, I can merge the two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment