New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make options optional for render #166

Merged
merged 1 commit into from Aug 31, 2018

Conversation

Projects
None yet
2 participants
@dagda1
Contributor

dagda1 commented Aug 31, 2018

I noticed a few things when trying to use this in an actual typescript project.

I've made document and customRenderer optionals in AfterRenderOptions:


export interface AfterRenderOptions<T> {
  req: Request;
  res: Response;
  assets: Assets;
  routes: AsyncRouteProps[];
  document?: AsyncRouteComponentType<T> | typeof DefaultDoc;
  customRenderer?: (element: React.ReactElement<T>) => { hthl: string };
}

Also exported the types. I probably need to name things better in that file but this is better for n ow.

Paul Cowan

@jaredpalmer jaredpalmer merged commit 7d6f5fe into jaredpalmer:master Aug 31, 2018

2 checks passed

security/snyk - examples/basic/package.json (jaredpalmer) No manifest changes detected
security/snyk - package.json (jaredpalmer) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment