New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings from production bundle #1161

Merged
merged 2 commits into from Dec 6, 2018

Conversation

2 participants
@TrySound
Copy link
Collaborator

TrySound commented Dec 6, 2018

dev-expression allows to add NODE_ENV conditions around invariant and
warning calls which eliminate a message in production and reduce bundle
size.

TrySound added some commits Dec 6, 2018

Remove warnings from production bundle
dev-expression allows to add NODE_ENV conditions around invariant and
warning calls which eliminate a message in production and reduce bundle
size.
@jaredpalmer

This comment has been minimized.

Copy link
Owner

jaredpalmer commented Dec 6, 2018

Love it! Keep these PRs coming!

In a perfect world, I'd love to setup an error message system like React cores's where messages are pulled out and replaced with references w/links to a URL (in both dev and prod)

@jaredpalmer jaredpalmer merged commit 731d13e into master Dec 6, 2018

5 checks passed

WIP ready for review
Details
ci/circleci: deploy-docs Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
security/snyk - package.json (jaredpalmer) No new issues
Details
security/snyk - website/package.json (jaredpalmer) No manifest changes detected

@jaredpalmer jaredpalmer deleted the dev-expression branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment