Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unnecessary let usage #1964

Merged
merged 1 commit into from Nov 1, 2019

Conversation

@karl-run
Copy link
Contributor

karl-run commented Oct 30, 2019

When only properties are updated on the error object it should be const not let.


View rendered docs/guides/validation.md

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Oct 30, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@jaredpalmer

This comment has been minimized.

Copy link
Owner

jaredpalmer commented Oct 30, 2019

Can you go through the /website/versioned_docs folder and update this everywhere on older versions?

When only properties are updated on the error object it should be `const` not `let`.
@karl-run karl-run force-pushed the karl-run:patch-2 branch from 6c5cb5e to dbfb687 Oct 31, 2019
@karl-run

This comment has been minimized.

Copy link
Contributor Author

karl-run commented Oct 31, 2019

A find replace should do the trick, the few places where let is correct doesn't assign an empty object as the initial value.

@jaredpalmer jaredpalmer merged commit a4ebf84 into jaredpalmer:master Nov 1, 2019
2 checks passed
2 checks passed
WIP Ready for review
Details
ci/codesandbox Building packages succeeded.
Details
@karl-run karl-run deleted the karl-run:patch-2 branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.