New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 16.3 #594
Merged
Merged
React 16.3 #594
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
04bec6f
Attempt move to React 16.3
jaredpalmer e439bb7
Add back React as peer dep
jaredpalmer 6deb4a7
Add hoist-non-react-statics to connect()
jaredpalmer c16c8e8
Remove any from hoistStatics in withFormik()
jaredpalmer c981f97
Introduct FormikContext<V> interface in addition to FormikProps<V>
jaredpalmer d83172d
Merge branch 'master' into react-16.3
jaredpalmer 0a82cac
Use a forked version of Enzyme that's compatible with React 16 :shrug:
jaredpalmer 3a7667e
Expose WrappedComponent with connect
jaredpalmer 78b01a6
Move from cWM to cDM in Formik tests
jaredpalmer b581d74
Start to use WrappedComponent in <Field> tests
jaredpalmer 1ba647a
Use WrappedComponent in FastField tests
jaredpalmer a90eb92
Fix FastField innerRef test
jaredpalmer f3f591a
Fix usage of getDerivedStateFromProps
jaredpalmer cbf1643
Remove @types/enzyme
jaredpalmer 4f29a85
Add back react as a peer dependency
jaredpalmer 8ac6c4f
Bump React version on website
jaredpalmer 99ccab8
Install formik from filesystem on website
jaredpalmer 7fd5f1e
Fix types for Field and FastField
jaredpalmer 3a3b10b
v1.0.0-alpha.r16.3.1
jaredpalmer ff344ff
Bump typescript version to 2.8.3
jaredpalmer 9e9e0cd
v1.0.0-alpha.r16.3.2
jaredpalmer fe812c2
Remove Fragment and export connect()
jaredpalmer 164f0e6
Fix 16.3 builds
jaredpalmer 1968a7f
Use esModuleInterop
jaredpalmer 7c01ab0
Fix builds, expose dev build like React does
jaredpalmer fe82f04
Move types to another directory
jaredpalmer 55d00f0
Fix size-limit
jaredpalmer fabf5b0
Add back size-limit
jaredpalmer File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,6 @@ | ||
import * as PropTypes from 'prop-types'; | ||
import * as React from 'react'; | ||
import { connect } from './connect'; | ||
|
||
export const Form: React.SFC<any> = (props, context) => ( | ||
<form onSubmit={context.formik.handleSubmit} {...props} /> | ||
); | ||
|
||
Form.contextTypes = { | ||
formik: PropTypes.object, | ||
}; | ||
export const Form = connect<any>(({ formik: { handleSubmit }, ...props }) => ( | ||
<form onSubmit={handleSubmit} {...props} /> | ||
)); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migration to
getDeriveStateFromProps
can be achieved with react-lifecycles-compatThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call