New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN doc: use submitForm instead of handleSubmit #710

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@slorber
Contributor

slorber commented Jun 26, 2018

it looks to me by convention that "handleX" are suited for dom usage. even if a recent fix allows handleSubmit to work on RN on the next beta (not yet published) I think the handleSubmit method has no additional value for RN projects, so calling submitForm looks more appropriate to me

RN doc: use submitForm instead of handleSubmit
it looks to me by convention that "handleX" are suited for dom usage. even if a recent fix allows `handleSubmit` to work on RN on the next beta (not yet published) I think the `handleSubmit` method has no additional value for RN projects, so calling `submitForm` looks more appropriate to me
@sshmyg

This comment has been minimized.

sshmyg commented Jun 27, 2018

@slorber Don't you think changes in API names will lead to big problems among formik current users?

@slorber

This comment has been minimized.

Contributor

slorber commented Jun 27, 2018

@sshmyg I don't change the api name, I'm only changing the doc, and it only affect the RN users. Note that the current doc RN examples do not work against latest release, that's why I'm correcting the doc in the first place: to provide examples that actually work fine. I don't think this will lead to big problems, it will actually help people trying to use Formik right now on a RN project, as now the doc will provide working examples

@stale

This comment has been minimized.

stale bot commented Oct 20, 2018

Hola! So here's the deal, between open source and my day job and life and what not, I have a lot to manage, so I use a GitHub bot to automate a few things here and there. This particular GitHub bot is going to mark this as stale because it has not had recent activity for a while. It will be closed if no further activity occurs in a few days. Do not take this personally--seriously--this is a completely automated action. If this is a mistake, just make a comment, DM me, send a carrier pidgeon, or a smoke signal.

@stale stale bot added the stale label Oct 20, 2018

@stale

This comment has been minimized.

stale bot commented Oct 27, 2018

ProBot automatically closed this due to inactivity. Holler if this is a mistake, and we'll re-open it.

@stale stale bot closed this Oct 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment