New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerender <FastField /> when isSubmitting has changed #915

Merged
merged 1 commit into from Sep 19, 2018

Conversation

2 participants
@stalmok
Copy link
Contributor

stalmok commented Sep 16, 2018

Resolves #906

@jaredpalmer

This comment has been minimized.

Copy link
Owner

jaredpalmer commented Sep 16, 2018

Please resolve conflicts

@stalmok stalmok force-pushed the stalmok:master branch from 9a26f9c to 8c74f7b Sep 16, 2018

@jaredpalmer jaredpalmer merged commit 63a87eb into jaredpalmer:master Sep 19, 2018

3 checks passed

WIP ready for review
Details
security/snyk - package.json (jaredpalmer) No manifest changes detected
security/snyk - website/package.json (jaredpalmer) No manifest changes detected
@jaredpalmer

This comment has been minimized.

Copy link
Owner

jaredpalmer commented Sep 19, 2018

Actually may revert this. I’m not sure this is needed.

@stalmok

This comment has been minimized.

Copy link
Contributor

stalmok commented Sep 19, 2018

My scenario is that the fields stay disabled if there are validation errors when user is trying to submit the form. Correct me if I'm wrong, Formik sets isSubmitting=true on submit and sets it back to isSubmitting=false if there are any validation errors.

How could I work around that while still using <FastField />? The performance with the <Field /> is not tolerable.

AntiFish03 added a commit to getaroom/formik that referenced this pull request Sep 19, 2018

Merge branch 'master' into add-focus-handling
* master:
  Rerender <FastField /> when  isSubmitting has changed (jaredpalmer#915)
  Update Snack example for React Native (jaredpalmer#919)
  Update examples with <ErrorMessage /> (jaredpalmer#908)

# Conflicts:
#	src/FastField.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment