Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcemaps for extractErrors plugin #184

Open
sw-yx opened this issue Aug 26, 2019 · 2 comments
Open

Sourcemaps for extractErrors plugin #184

sw-yx opened this issue Aug 26, 2019 · 2 comments
Labels
help wanted Extra attention is needed kind: feature New feature or request

Comments

@sw-yx
Copy link
Collaborator

sw-yx commented Aug 26, 2019

Current Behavior

currently our transformErrorMessages plugin doesnt provide a source map. this breaks sourcemap behavior downstream.

Desired Behavior

sourcemapz

Suggested Solution

add teh sourcemap

Who does this impact? Who is this for?

all extractErrors users

Additional context

clues we can use to implement this

@jaredpalmer
Copy link
Owner

jaredpalmer commented Aug 27, 2019

I’m not going to have time to dig into this for a while. Would love for someone to jump in and help.

@sw-yx
Copy link
Collaborator Author

sw-yx commented Aug 27, 2019

ya i dont consider this very high priority at the moment and may revisit when this bothers me enough. its just interesting that the fb rollup/babel implementation doesnt do any sourcemap specific code and it Just Works

edit: ah. they turn off sourcemaps??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind: feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants