Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More frequent releases please! #512

stevesims opened this issue Feb 18, 2020 · 7 comments

More frequent releases please! #512

stevesims opened this issue Feb 18, 2020 · 7 comments


Copy link

stevesims commented Feb 18, 2020

Current Behavior

As of writing, the current release of tsdx is 0.12.3, which came out over 5 weeks ago, and there has since been 34 new commits, half of which have brought new or revised functionality. This new functionality, as it has not been released, is not readily accessible to users of tsdx.

Desired Behavior

More frequent updates please!

Suggested Solution

Adopt a continuous release strategy. When code is merged into master (and all tests are passing) a new release should be made.

If current tests are insufficient to ensure that the latest master branch is safe for release, then new tests should be added. 😀

Some discussion on automated releases can be found in #254

Who does this impact? Who is this for?

All users of tsdx.

Describe alternatives you've considered

I have tried to run tsdx directly from the github repo using npx github:jaredpalmer/tsdx create package-name however as of the time of writing this failed with the following error:

npm ERR! prepareGitDep src/index.ts(349,11): error TS2367: This condition will always return 'false' since the types '"START" | "BUNDLE_START" | "BUNDLE_END" | "END" | "ERROR"' and '"FATAL"' have no overlap.
npm ERR! prepareGitDep src/index.ts(351,24): error TS2339: Property 'error' does not exist on type 'RollupWatcherEvent'.
npm ERR! prepareGitDep   Property 'error' does not exist on type '{ code: "START"; }'.

Additional context


Copy link

agilgur5 commented Mar 6, 2020

Seems like TSDX isn't alone: jaredpalmer/razzle#1159 😕

I've emailed Jared to ask to make me a collaborator here and on NPM or move TSDX to an org. We'll see if there's any progress there.

Copy link

agilgur5 commented Mar 10, 2020

So I was added as a collaborator yesterday and on my first day I closed 35+ issues, closed out ~15 PRs, and triaged, consolidated, labeled, etc, about 50% of open and closed issues. (and deleted 60+ unnecessary stale branches, mostly from greenkeeper)
Did some more triage (~80% total), closing issues (~5), and merging PRs (~5) today.

But unfortunately I wasn't yet added as a collaborator on NPM, so I can't yet make releases.
That being said, I did merge #544 , so you should now be able to install from GitHub without the error listed above.

Copy link

jaredpalmer commented Mar 11, 2020

Sorry I have been a bit MIA. Have been cranking on Formik Inc. now full time and haven’t been on GitHub much. Similarly Shawn (@sw-yx) is crazy busy as well. Giving contributor and publish rights to @agilgur5 who has done an amazing job with this project over the last several months


This comment has been minimized.

Copy link

agilgur5 commented Mar 20, 2020

Jared gave me publishing rights yesterday so I just published v0.13.0. Sorry for the long delay everyone.

Please see #254 for discussions on automated releases.

I've now triaged ~95% of all open and closed issues, have basically read through all of them. Not all are resolved yet of course, but I've closed, resolved, labeled, marked as duplicate / support / etc many.

Still have 2 more PRs to review (the ones on custom templates), the rest I've already reviewed or are authored by me (or are automated dependency updates).

Might start using milestones for better transparency on Roadmap, but hard to predict where/when things may land.

(Also deleted 120+ more stale greenkeeper branches, something like ~2/3s of the total)

Have also added everyone who's contributed PRs as contributors in All Contributors (hence the 74 commits/PRs of such in the log). Probably still a good portion of people who contributed bug reports or ideas that haven't been credited yet though. That's on backlog, but ping me with links to your contributions if you want to be credited near-term.

Copy link

stevesims commented Mar 20, 2020

Dude, that's awesome. Fantastic work. 😀

Copy link

sw-yx commented Mar 25, 2020

awesome work @agilgur5 - i'm not making as many react + TS libraries as I used to hence my usage of TSDX itself has slowed in recent months. But I am sure that I will be back. glad that TSDX is in good hands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

No branches or pull requests

5 participants