Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Automated g4 rollback

*** Reason for rollback ***

This fix turned out to be a bad idea.  Due to the order in which xhrio.js handles various aspets of the ready state change, it's not yet publishing the HTTP_ERROR status code when its version of the ready state change is dispatched.

*** Original change description ***

Fix some code which I suspect was leading to the browser channel sometimes publishing bogus server reachability events.  ChannelRequest was reading an XhrIo's http status code without checking that it had raised an http status error.

R=nicksantos
DELTA=1  (0 added, 0 deleted, 1 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=5799


git-svn-id: http://closure-library.googlecode.com/svn/trunk@2291 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  • Loading branch information...
commit 64e6ec480a17dec8d692c02705b7d08b8d32de8e 1 parent e91aae0
dbk@google.com authored
Showing with 1 addition and 1 deletion.
  1. +1 −1  closure/goog/net/channelrequest.js
View
2  closure/goog/net/channelrequest.js
@@ -647,7 +647,7 @@ goog.net.ChannelRequest.prototype.onXmlHttpReadyStateChanged_ = function() {
// Pretty conservative, these are the only known scenarios which we'd
// consider indicative of a truly non-functional network connection.
if (errorCode == goog.net.ErrorCode.TIMEOUT ||
- (errorCode == goog.net.ErrorCode.HTTP_ERROR && statusCode <= 0)) {
+ statusCode <= 0) {
this.channel_.notifyServerReachabilityEvent(
goog.net.BrowserChannel.ServerReachability.REQUEST_FAILED);
} else {
Please sign in to comment.
Something went wrong with that request. Please try again.