Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Return value of goog.events and goog.events.listenOnce is going to

change from ?number to goog.events.ListenableKey. As a first step, we
are switching the return value to a typedef goog.events.Key (currently
just typedef to ?number). This CL switches JS files to use this typedef.

Obviously, the subsequent change will be problematic if this code
make an assumption that the return value is a number and uses the return
value in context where the number is required (e.g. goog.isNumber, using
it as index to an array). While I've tried my best to fix these usages,
I may have missed some of them. Please check that the code will still
remain correct if the return value of goog.events.listen/listenOnce is
changed to an object (goog.events.ListenableKey). Furthermore, if
you know of any other location where the return value is used in a context
that require it to be numbers, please send me a quick email.

R=davec
DELTA=3 (0 added, 0 deleted, 3 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=6200


git-svn-id: http://closure-library.googlecode.com/svn/trunk@2470 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  • Loading branch information...
commit c9c880db3433d7183339a9d3afd58ef9cbb09e72 1 parent 1c8cd97
chrishenry@google.com authored
Showing with 3 additions and 3 deletions.
  1. +3 −3 closure/goog/dom/bufferedviewportsizemonitor.js
View
6 closure/goog/dom/bufferedviewportsizemonitor.js
@@ -73,15 +73,15 @@ goog.dom.BufferedViewportSizeMonitor = function(
/**
* Listener key for the viewport size monitor.
- * @type {number}
+ * @type {goog.events.Key}
* @private
*/
- this.listenerKey_ = /** @type {number} */ (goog.events.listen(
+ this.listenerKey_ = goog.events.listen(
viewportSizeMonitor,
goog.events.EventType.RESIZE,
this.handleResize_,
false,
- this));
+ this);
};
goog.inherits(goog.dom.BufferedViewportSizeMonitor, goog.events.EventTarget);
Please sign in to comment.
Something went wrong with that request. Please try again.