Permalink
Switch branches/tags
Nothing to show
Commits on Feb 8, 2013
  1. Track all template renders when goog.DEBUG is true

    mknichel@google.com committed Feb 8, 2013
    R=panicker,gboyer
    DELTA=226 (214 added, 3 deleted, 9 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6272
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2519 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
Commits on Feb 7, 2013
  1. Add a missing space an error. The error becomes confusing without it.

    johnem@google.com committed Feb 7, 2013
    R=vbhasin
    DELTA=1 (0 added, 0 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6271
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2518 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  2. Change return value of goog.events.listen/listenOnce and param

    chrishenry@google.com committed Feb 7, 2013
    to goog.events.unlistenByKey to be number|goog.events.ListenableKey.
    
    This does not actually change the implementation.
    
    R=nicksantos
    DELTA=1 (0 added, 0 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6270
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2517 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  3. Add goog.array.range for generating numeric ranges.

    brenneman@google.com committed Feb 7, 2013
    This produces the same results as
    goog.iter.toArray(goog.iter.range(...)), but a little more directly.
    
    R=arv
    DELTA=71 (71 added, 0 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6269
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2516 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  4. Extract the JS test from positioning_test.html into its own file.

    nnaze@google.com committed Feb 7, 2013
    R=nicksantos
    DELTA=2204 (1121 added, 1080 deleted, 3 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6268
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2515 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  5. Create a new goog.string.newlines package for dealing with

    nnaze@google.com committed Feb 7, 2013
    line splitting, etc.
    
    R=nicksantos
    DELTA=341 (282 added, 58 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6267
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2514 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
Commits on Feb 6, 2013
  1. Fix bug , "Able to select both the radio buttons in the "Insert link"…

    carlanton@google.com committed Feb 6, 2013
    … popup window using keyboard tab."
    
    R=nicksantos
    DELTA=125 (90 added, 9 deleted, 26 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6266
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2513 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  2. Adds a getKthValue method to goog.structs.AvlTree that runs in O(log …

    danchen@google.com committed Feb 6, 2013
    …n) time.
    
    R=chrishenry
    DELTA=163 (133 added, 21 deleted, 9 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6265
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2512 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  3. Fix positioning test for chrome-linux. Browser size change

    nnaze@google.com committed Feb 6, 2013
    is causing bad values on positioning.
    
    R=chrishenry
    DELTA=5 (4 added, 0 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6264
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2511 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  4. Add goog.dom.classlist.addAll() convenience method. Also restore the …

    jeffschiller@google.com committed Feb 6, 2013
    …way native DOMTokenList is determined now that javascript/externs.js has added DOMTokenList.
    
    R=arv,nicksantos
    DELTA=60 (58 added, 0 deleted, 2 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6263
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2510 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
Commits on Feb 5, 2013
  1. Make goog.events.testing.mixinListenable also mixin

    chrishenry@google.com committed Feb 5, 2013
    goog.Disposable stuff, so that it can be disposed correctly.
    
    R=nicksantos
    DELTA=8 (7 added, 0 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6262
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2509 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  2. Use the specific vendor prefix of the rendering engine when setting c…

    chrisq@google.com committed Feb 5, 2013
    …ss transition.
    
    R=chrishenry
    DELTA=75 (16 added, 40 deleted, 19 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6261
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2508 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  3. Fix issues blocking the JSCompiler release

    nicksantos@google.com committed Feb 5, 2013
    Most of these consist of
    - invalid type casts
    - function declarations in 'if' blocks, which are forbidden in
    future versions of JS
    - bad generic types
    
    DELTA=2 (2 added, 0 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6260
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2507 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
Commits on Feb 4, 2013
  1. Remove the silverlight code from Closure

    nicksantos@google.com committed Feb 4, 2013
    I could never really get this to work well, and silverlight
    is a dead technology
    
    R=nnaze,cbro,jch
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6253
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2506 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  2. Make validator a bit smarter about allowed email addresses. A number of

    mariakhomenko@google.com committed Feb 4, 2013
    special characters are valid in the email address spec.
    http://en.wikipedia.org/wiki/Email_address#Syntax
    
    R=nnaze
    DELTA=7 (2 added, 0 deleted, 5 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6252
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2505 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  3. Update two colors to match the CSS3 spec (http://www.w3.org/TR/css3-c…

    slieberman@google.com committed Feb 4, 2013
    …olor/#svg-color).
    
    The previous mismatch seems similar to: https://code.google.com/p/chromium/issues/detail?id=69428
    
    R=vbhasin
    DELTA=2 (0 added, 0 deleted, 2 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6250
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2504 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  4. Makes input tools and firststrong compatible.

    fengyuan@google.com committed Feb 4, 2013
    R=shuchen,wuyingbing,nicksantos,ajp,nkerem
    DELTA=85 (78 added, 0 deleted, 7 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6249
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2503 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  5. Provide minimal screen reader support when tabbing through the cells of

    mturcotte@google.com committed Feb 4, 2013
    the character picker. This CL also add a CSS rule to provide visual
    feedback when the focus is on a given cell.
    
    R=lauriat,ipi,chrishenry
    DELTA=153 (143 added, 3 deleted, 7 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6248
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2502 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
Commits on Feb 2, 2013
  1. Updating goog.db to comply with the latest specs regarding error repo…

    dpapad@google.com committed Feb 2, 2013
    …rting.
    
    See http://www.w3.org/TR/IndexedDB/#exceptions
    
    Errors used to be reported as numerical error codes. Now they are reported
    as strings. Chrome25 is the first version that is not backward compatible.
    Chrome 22, 23, 24 support both.
    
    R=nweiz
    DELTA=328 (215 added, 20 deleted, 93 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6247
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2501 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
Commits on Feb 1, 2013
  1. Remove reference to ".toString(36)" in common code so it is easier fo…

    johnlenz@google.com committed Feb 1, 2013
    …r the compiler to remove.
    
    R=nicksantos
    DELTA=3 (0 added, 1 deleted, 2 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6246
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2500 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  2. Add goog.string splitLines function.

    nnaze@google.com committed Feb 1, 2013
    Pull JS from string_test.html into string_test.js in this change.
    
    R=nicksantos
    DELTA=58 (58 added, 0 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6245
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2499 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  3. Replace calls:

    chrishenry@google.com committed Feb 1, 2013
    goog.mixin(x, new goog.events.EventTarget());
    
    with:
    goog.testing.events.mixinListenable(x);
    
    The former will no longer works when we flip the @define
    goog.events.Listenable.USE_LISTENABLE_INTERFACE to true.
    
    Please review that the change is as intended above. Since this
    is done automatically (with multiple spot-checks), there may be cases
    where the output is not as expected. Let me know if you spot any
    and I will fix it.
    
    This is part of goog.events leaking listeners elimination
    effort
    
    R=mschidlowsky
    DELTA=2 (1 added, 0 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6244
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2498 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
Commits on Jan 31, 2013
  1. Move JS out of string_test.html and into string_test.js

    nnaze@google.com committed Jan 31, 2013
    R=nicksantos
    DELTA=2152 (1090 added, 1058 deleted, 4 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6243
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2497 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  2. Make goog.ui.Component calls super-class disposeInternal last.

    chrishenry@google.com committed Jan 31, 2013
    R=gboyer
    DELTA=4 (1 added, 2 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6242
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2496 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  3. Fixed missing required statements for goog.a11y.aria.State and goog.a…

    atincheva@google.com committed Jan 31, 2013
    …11y.aria.Role (and goog.a11y.aria).
    
    This is required because a following step in the goog.a11y.aria
    refactoring is to split the goog.a11y.aria.Role and goog.a11y.aria.State in separate files.
    A further refactoring will be to autogenerate the enums, so they should not be mixed with
    not autogenerated content.
    This change should not affect any BUILD files, as the goog.a11y.aria.State and goog.a11y.aria.Role are still
    in the aria.js file. The next change will affect only BUILD files.
    The changes are made by applying sed replacement transformations, so please double check the additions.
    
    
    Thanks a lot for your cooperation!
    
    Nelly
    
    R=dnadasi
    DELTA=2 (1 added, 0 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6236
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2495 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  4. Add the ability to specify the current intended filename via a global

    malteubl@google.com committed Jan 31, 2013
    variable to goog.debug and change the module compiler to set this
    when compiling in the "one eval per file mode".
    
    This improves error reporting in the case of syntax errors, which happen
    before the //@ sourceURL annotation in the eval is parsed.
    
    R=nicksantos
    DELTA=8 (5 added, 0 deleted, 3 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6235
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2494 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  5. Fixed tests that will be broken by goog.events refactoring,

    chrishenry@google.com committed Jan 31, 2013
    which is reversing the role of goog.events and
    goog.events.EventTarget. goog.events now delegate to
    goog.events.EventTarget.
    
    The fixes are usually variations of the following issues:
    1) Use-after-dispose of an event target -- this no longer works.
    2) Overly strick mock -- we now may call methods such as listen,
    listenOnce, etc. on the event target.
    3) Improperly set up mock -- if a mock is passed to e.g.
    goog.events.listen before calling $replay, it will
    incorrectly sets up expectation for listen() calls (because
    goog.events.listen now calls EventTarget#listen).
    4) Wrong calls/parameters in the first place. (EventTarget is
    slightly stricter than goog.events.)
    
    If you are unsure about what problem I am fixing exactly, feel
    free to ping me on the CL thread.
    
    This is part of goog.events leaking listeners clean up effort.
    
    R=loreena
    DELTA=1 (1 added, 0 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6234
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2493 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  6. Fix an issue where getScrollLeft() returns an incorrect value in

    mariakhomenko@google.com committed Jan 31, 2013
    non-gecko/non-IE browsers (e.g. Webkit) when the element has overflow
    visible.
    
    R=nicksantos
    DELTA=27 (25 added, 0 deleted, 2 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6233
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2492 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  7. Remove double goog.require of goog.events.Listenable.

    chrishenry@google.com committed Jan 31, 2013
    R=dpapad
    DELTA=4 (1 added, 2 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6232
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2491 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  8. Add goog.testing.events.mixinListenable to allow mixing in

    chrishenry@google.com committed Jan 31, 2013
    listenable capability to objects in tests. This can be used to
    make mock object be able to also handle events properly.
    
    R=nicksantos
    DELTA=99 (93 added, 2 deleted, 4 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6231
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2490 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
Commits on Jan 30, 2013
  1. Make hostPrefix initialization use the same initialization irrespecti…

    arunabhaghosh@google.com committed Jan 30, 2013
    …ve of the shortcircuiting of the first test.
    
    R=dennygursky,mpd
    DELTA=3 (1 added, 1 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6230
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2489 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  2. Automated g4 rollback

    xtof@google.com committed Jan 30, 2013
    *** Reason for rollback ***
    
    rolling back rollback
    
    *** Original change description ***
    
    Automated g4 rollback
    
    *** Reason for rollback ***
    
    Broke stuff
    
    *** Original change description ***
    
    Restrict goog.soy.Renderer.render to only render strict Soy templates of kind="html".
    
    Also, strenghten .renderStrict to assume kind="html" if called without explicit kind in opt_kind parameter.
    
    R=gboyer
    DELTA=40 (36 added, 0 deleted, 4 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6229
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2488 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  3. Made positioning resize correctly when overflow happens at the top. I…

    mschidlowsky@google.com committed Jan 30, 2013
    …t was already doing the right thing when it overflowed at the bottom.
    
    R=nicksantos
    DELTA=17 (17 added, 0 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6228
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2487 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  4. Add capture support for ActionEventWrapper.listen and .unlisten.

    jcaballero@google.com committed Jan 30, 2013
    R=eae
    DELTA=54 (49 added, 0 deleted, 5 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6223
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2486 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  5. Ensure that classes inheriting from goog.events.EventTarget

    chrishenry@google.com committed Jan 30, 2013
    also calls super-class constructor. This is becoming necessary
    because we plan to submit a change that will require
    initialization in the EventTarget constructor.
    
    This change is made by adding goog.base(this); to the first
    line of constructors inheriting directly from
    goog.events.EventTarget. Thus, reviewers should ensure that
    there is no other call to super-class constructor in the
    constructor body.
    
    This is part of goog.events leaking listeners elimination
    effort.
    
    R=dnadasi
    DELTA=2 (2 added, 0 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6222
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2485 0b95b8e8-c90f-11de-9d4f-f947ee5921c8