Permalink
Switch branches/tags
Nothing to show
Commits on Jan 30, 2013
  1. A few fixes to goog.events+goog.events.EventTarget:

    chrishenry@google.com
    chrishenry@google.com committed Jan 30, 2013
    1) Adds reallyDisposed_ to goog.events.EventTarget. Use this
    to bypass dispatchEvent/fireListeners instead of this.isDisposed().
    Reason: this.isDisposed() returns true when dispose() is called,
    even when disposeInternal has not been executed. Many classes
    (including goog.ui.Component) wants to fire events in
    disposeInternal, which should be allowed. Added test.
    
    2) wrapListener_ now returns the value from handleEvent call
    correctly + added tests.
    
    R=nicksantos
    DELTA=70 (65 added, 0 deleted, 5 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6221
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2484 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  2. Automated g4 rollback

    xtof@google.com
    xtof@google.com committed Jan 30, 2013
    *** Reason for rollback ***
    
    Broke
    
    *** Original change description ***
    
    Restrict goog.soy.Renderer.render to only render strict Soy templates of kind="html".
    
    Also, strenghten .renderStrict to assume kind="html" if called without explicit kind in opt_kind parameter.
    
    DELTA=40 (0 added, 36 deleted, 4 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6220
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2483 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  3. Restrict goog.soy.Renderer.render to only render strict Soy templates…

    xtof@google.com
    xtof@google.com committed Jan 30, 2013
    … of kind="html".
    
    Also, strenghten .renderStrict to assume kind="html" if called without explicit kind in opt_kind parameter.
    
    R=gboyer
    DELTA=40 (36 added, 0 deleted, 4 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6219
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2482 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  4. Ensure that classes inheriting from goog.events.EventTarget

    chrishenry@google.com
    chrishenry@google.com committed Jan 30, 2013
    also calls super-class constructor. This is becoming necessary
    because we plan to submit a change that will require
    initialization in the EventTarget constructor.
    
    This change is made by adding goog.base(this); to the first
    line of constructors inheriting directly from
    goog.events.EventTarget. Thus, reviewers should ensure that
    there is no other call to super-class constructor in the
    constructor body.
    
    This is part of goog.events leaking listeners elimination
    effort.
    
    R=ajp,dbeam
    DELTA=6 (6 added, 0 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6218
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2481 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
Commits on Jan 29, 2013
  1. Fulfill a goog.ui.Dialog TODO to make shift-tabbing from the top of t…

    ssw@google.com
    ssw@google.com committed Jan 29, 2013
    …he dialog wrap backward to the last tabbable element in the dialog. This helps improve keyboard accessibility.
    
    Tested on a variety of Closure dialogs in Chrome 25, Firefox 18, Safari 6, IE9.
    
    R=nicksantos
    DELTA=72 (67 added, 1 deleted, 4 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6217
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2480 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  2. fix percentage format for lt before CLDR fix.

    shanjian@google.com
    shanjian@google.com committed Jan 29, 2013
    R=mscherer
    DELTA=3 (2 added, 0 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6216
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2479 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  3. Return value of goog.events and goog.events.listenOnce is going to

    chrishenry@google.com
    chrishenry@google.com committed Jan 29, 2013
    change from ?number to goog.events.ListenableKey. As a first step, we
    are switching the return value to a typedef goog.events.Key (currently
    just typedef to ?number). This CL switches JS files to use this typedef.
    
    Obviously, the subsequent change will be problematic if this code
    make an assumption that the return value is a number and uses the return
    value in context where the number is required (e.g. goog.isNumber, using
    it as index to an array). While I've tried my best to fix these usages,
    I may have missed some of them. Please check that the code will still
    remain correct if the return value of goog.events.listen/listenOnce is
    changed to an object (goog.events.ListenableKey). Furthermore, if
    you know of any other location where the return value is used in a context
    that require it to be numbers, please send me a quick email.
    
    This is parts of goog.events refactoring to remove leaking listeners
    problem.
    
    R=dnadasi,pallosp
    DELTA=9 (0 added, 0 deleted, 9 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6215
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2478 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  4. Make a number of private properties that were being used as

    nnaze@google.com
    nnaze@google.com committed Jan 29, 2013
    protected properties protected so that we can move
    javascript/closure/compiledClosure to visibility=error.
    
    R=chrishenry,nicksantos
    DELTA=137 (40 added, 15 deleted, 82 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6214
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2477 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  5. Automated g4 rollback

    nnaze@google.com
    nnaze@google.com committed Jan 29, 2013
    *** Reason for rollback ***
    
    rolling forward
    
    *** Original change description ***
    
    Automated g4 rollback
    
    *** Reason for rollback ***
    
    causing build breakages, investigating
    
    *** Original change description ***
    
    Fix reference to private property in mockactivitymonitor.
    
    R=chrishenry
    DELTA=149 (128 added, 1 deleted, 20 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6213
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2476 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  6. Automated g4 rollback

    nnaze@google.com
    nnaze@google.com committed Jan 29, 2013
    *** Reason for rollback ***
    
    causing build breakages, investigating
    
    *** Original change description ***
    
    Fix reference to private property in mockactivitymonitor.
    
    DELTA=149 (1 added, 128 deleted, 20 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6212
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2475 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  7. Fix reference to private property in mockactivitymonitor.

    nnaze@google.com
    nnaze@google.com committed Jan 29, 2013
    R=chrishenry
    DELTA=149 (128 added, 1 deleted, 20 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6207
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2474 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
Commits on Jan 28, 2013
  1. Fix positioning test that fails when the anchor is partially visible.

    nnaze@google.com
    nnaze@google.com committed Jan 28, 2013
    This is causing a failure when testing team is updating its
    browser sizes.
    
    R=chrishenry
    DELTA=6 (4 added, 0 deleted, 2 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6206
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2473 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  2. Make the dimension picker only accept highlighted values between (1,1…

    vikki@google.com
    vikki@google.com committed Jan 28, 2013
    …) and (maxColumns, maxRows), inclusive. This makes interacting with it via keyboardand mouse more consistent. This also improves a11y for the component.
    
    Also fixes a type warning in setValue().
    
    R=nicksantos
    DELTA=66 (33 added, 5 deleted, 28 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6205
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2472 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  3. Deprecate goog.dom.a11y.

    atincheva@google.com
    atincheva@google.com committed Jan 28, 2013
    R=chrishenry,nnaze,ruilopes
    DELTA=28 (24 added, 4 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6201
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2471 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  4. Return value of goog.events and goog.events.listenOnce is going to

    chrishenry@google.com
    chrishenry@google.com committed Jan 28, 2013
    change from ?number to goog.events.ListenableKey. As a first step, we
    are switching the return value to a typedef goog.events.Key (currently
    just typedef to ?number). This CL switches JS files to use this typedef.
    
    Obviously, the subsequent change will be problematic if this code
    make an assumption that the return value is a number and uses the return
    value in context where the number is required (e.g. goog.isNumber, using
    it as index to an array). While I've tried my best to fix these usages,
    I may have missed some of them. Please check that the code will still
    remain correct if the return value of goog.events.listen/listenOnce is
    changed to an object (goog.events.ListenableKey). Furthermore, if
    you know of any other location where the return value is used in a context
    that require it to be numbers, please send me a quick email.
    
    R=davec
    DELTA=3 (0 added, 0 deleted, 3 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6200
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2470 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
Commits on Jan 27, 2013
  1. Ensure that unlisten/unlistenByKey does not fail when called

    chrishenry@google.com
    chrishenry@google.com committed Jan 27, 2013
    on disposed EventTarget. This turns out to be pretty common
    when you have a disposed event target stored in an
    EventHandler.
    
    R=nicksantos
    DELTA=21 (17 added, 4 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6199
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2469 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
Commits on Jan 26, 2013
  1. Adds actual logic to allow goog.events to delegate to

    chrishenry@google.com
    chrishenry@google.com committed Jan 26, 2013
    goog.events.Listenable when appropriate.
    
    R=nicksantos,gboyer
    DELTA=218 (191 added, 4 deleted, 23 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6198
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2468 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
Commits on Jan 25, 2013
  1. BRs aren't the only elements that shouldn't act as a range endpoint. …

    pappy@google.com
    pappy@google.com committed Jan 25, 2013
    …Any element that can't have children are in the same boat.
    
    R=nnaze
    DELTA=6 (3 added, 0 deleted, 3 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6197
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2467 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
Commits on Jan 24, 2013
  1. Redirect all usages of goog.dom.a11y to goog.a11y.aria.

    atincheva@google.com
    atincheva@google.com committed Jan 24, 2013
    The changes are made by applying replace_string transformations, so
    please double check the replacements.
    
    R=chrishenry,nnaze,ruilopes
    DELTA=829 (276 added, 65 deleted, 488 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6196
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2466 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  2. Adds goog.soy.Renderer.prototype.renderText.

    xtof@google.com
    xtof@google.com committed Jan 24, 2013
    R=gboyer
    DELTA=43 (43 added, 0 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6195
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2465 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  3. Fixes a backwards compatibility issue with the Vec2.scale function

    markcollins@google.com
    markcollins@google.com committed Jan 24, 2013
    R=martone,nnaze
    DELTA=26 (20 added, 1 deleted, 5 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6194
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2464 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  4. Dispose the Cursor object after getAll completes.

    scr@google.com
    scr@google.com committed Jan 24, 2013
    R=nicksantos
    DELTA=55 (54 added, 0 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6193
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2463 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  5. Add getListener and hasListener to Listenable/EventTarget.

    chrishenry@google.com
    chrishenry@google.com committed Jan 24, 2013
    R=nicksantos
    DELTA=124 (118 added, 0 deleted, 6 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6192
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2462 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  6. Closure related changes to support BrowserChannel Startup optimization.

    arunabhaghosh@google.com
    arunabhaghosh@google.com committed Jan 24, 2013
    R=dennygursky,mpd
    DELTA=36 (35 added, 0 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6191
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2461 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
Commits on Jan 23, 2013
  1. Adding goog.string.path#extension method.

    dpapad@google.com
    dpapad@google.com committed Jan 23, 2013
    R=nnaze
    DELTA=41 (41 added, 0 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6190
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2460 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  2. Reimplement registerDisposable in term of on-dispose callback.

    chrishenry@google.com
    chrishenry@google.com committed Jan 23, 2013
    Presumably, unless you're creating and disposing object in hot loop
    (if you do that, you should probably fix that anyway),
    slight loss in performance should not matter (I'm not even sure this
    will actually be slower, given that goog.disposeAll creates an
    arguments object).
    
    R=nnaze
    DELTA=15 (0 added, 14 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6180
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2459 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  3. Remove the empty disposeInternal method from goog.net.XhrManager.Event.

    pallosp@google.com
    pallosp@google.com committed Jan 23, 2013
    R=scr,marja
    DELTA=5 (0 added, 5 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6179
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2458 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  4. Set the aria-hidden attribute when setting the visibility of a control.

    michaelthomas@google.com
    michaelthomas@google.com committed Jan 23, 2013
    R=nnaze
    DELTA=115 (104 added, 1 deleted, 10 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6178
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2457 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
Commits on Jan 22, 2013
  1. Documentation is wrong, 'DefaultConfig' -> 'defaultConfig'.

    fraser@google.com
    fraser@google.com committed Jan 22, 2013
    R=arv
    DELTA=4 (0 added, 0 deleted, 4 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6177
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2456 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  2. Add renderStrict that returns the same SanitziedContent as the input.

    gboyer@google.com
    gboyer@google.com committed Jan 22, 2013
    R=xtof
    DELTA=61 (60 added, 0 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6176
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2455 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
  3. Implemented a variant of Math.floor and Math.ceil which tolerate smal…

    pallosp@google.com
    pallosp@google.com committed Jan 22, 2013
    …l rounding errors in the passed floating point number.
    
    R=chrishenry
    DELTA=63 (62 added, 0 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6171
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2454 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
Commits on Jan 21, 2013
  1. Return value of goog.events and goog.events.listenOnce is going to

    chrishenry@google.com
    chrishenry@google.com committed Jan 21, 2013
    change from ?number to goog.events.ListenableKey. As a first step, we
    are switching the return value to a typedef goog.events.Key (currently
    just typedef to ?number). This CL switches JS files to use this typedef.
    
    Obviously, the subsequent change will be problematic if this code
    make an assumption that the return value is a number and uses the return
    value in context where the number is required (e.g. goog.isNumber, using
    it as index to an array). While I've tried my best to fix these usages,
    I may have missed some of them. Please check that the code will still
    remain correct if the return value of goog.events.listen/listenOnce is
    changed to an object (goog.events.ListenableKey). Furthermore, if
    you know of any other location where the return value is used in a context
    that require it to be numbers, please send me a quick email.
    
    This is parts of goog.events refactoring to remove leaking listeners
    problem.
    
    R=nweiz,nicksantos
    DELTA=20 (0 added, 2 deleted, 18 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6170
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2453 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
Commits on Jan 20, 2013
  1. Some cleanups before introducing Listenable handling to goog.events:

    chrishenry@google.com
    chrishenry@google.com committed Jan 20, 2013
    * Add goog.events.cleanUp that cleans up goog.events internal
    data structure given a ListenableKey.
    
    * Move key number generation to goog.events.ListenableKey.
    
    * Rejigger code in goog.events to refer to
    goog.events.listeners_ in as little places as possible
    (subsequent logic to unify handling for DOM events and
    Listenable will be cleaner, as listen_ will just return a
    ListenableKey and listen/listenOnce will handle putting the
    object into listeners_ array).
    
    R=nicksantos,gboyer
    DELTA=137 (104 added, 16 deleted, 17 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6169
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2452 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
Commits on Jan 18, 2013
  1. Fix for component being disposed before the timeout function is called.

    mleibman@google.com
    mleibman@google.com committed Jan 18, 2013
    R=nicksantos
    DELTA=4 (3 added, 0 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6168
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2451 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
Commits on Jan 17, 2013
  1. Allows matchers to be used for function call verifications.

    jemunoz@google.com
    jemunoz@google.com committed Jan 17, 2013
    R=vbhasin,nnaze,chrishenry
    DELTA=66 (62 added, 0 deleted, 4 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6164
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2450 0b95b8e8-c90f-11de-9d4f-f947ee5921c8