Permalink
Commits on Jan 17, 2013
  1. Enable the users of goog.userAgent to differentiate between chrome on…

    … Android, iPhone, and iPad.
    
    R=martone
    DELTA=156 (140 added, 0 deleted, 16 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6163
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2449 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    vbhasin@google.com committed Jan 17, 2013
  2. Return value of goog.events and goog.events.listenOnce is going to

    change from ?number to goog.events.ListenableKey. As a first step, we
    are switching the return value to a typedef goog.events.Key (currently
    just typedef to ?number). This CL switches JS files to use this typedef.
    
    Obviously, the subsequent change will be problematic if this code
    make an assumption that the return value is a number and uses the return
    value in context where the number is required (e.g. goog.isNumber, using
    it as index to an array). While I've tried my best to fix these usages,
    I may have missed some of them. Please check that the code will still
    remain correct if the return value of goog.events.listen/listenOnce is
    changed to an object (goog.events.ListenableKey). Furthermore, if
    you know of any other location where the return value is used in a context
    that require it to be numbers, please send me a quick email.
    
    This is parts of goog.events refactoring to remove leaking listeners
    problem.
    
    Tested:
    TAP presubmits for global presubmit queue
    http://test/OCL:41250199:BASE:41269811:1358405130847:6908b354
    Some tests failed; test failures are believed to be unrelated to this CL
    
    R=cibu
    DELTA=6 (0 added, 0 deleted, 6 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6162
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2448 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    chrishenry@google.com committed Jan 17, 2013
  3. Closure: Fix 1x1 matrix inverse bug

    R=brenneman
    DELTA=13 (12 added, 1 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6161
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2447 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    wattenberg@google.com committed Jan 17, 2013
Commits on Jan 16, 2013
  1. IE10 nows supports stack traces. See http://blogs.msdn.com/b/ie/archi…

    …ve/2012/05/10/diagnosing-javascript-errors-faster-with-error-stack.aspx.
    
    This cl adds IE10 stack trace support to closure.
    
    R=pallosp
    DELTA=76 (70 added, 0 deleted, 6 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6151
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2446 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    joonlee@google.com committed Jan 16, 2013
  2. Fixing a bug in closure event handling that makes event bubbling break

    when an event listener refires an event of the same type. The current
    code keeps count of the number of possible event targets in a global
    variable. The second event exhausts this count preventing the first
    event from bubbling completely. This CL fixes this by using a counter on
    the stack and comparing to the current count in the targets map.
    
    R=nicksantos,josephkaptur,mtragut
    DELTA=132 (130 added, 0 deleted, 2 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6150
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2445 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    albright@google.com committed Jan 16, 2013
  3. Expose yet another DragListGroup bug in the demo which is related to …

    …different drag item widths.
    
    R=ponny
    DELTA=29 (26 added, 0 deleted, 3 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6149
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2444 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    pallosp@google.com committed Jan 16, 2013
  4. Allow canceling the parent Results of a combined, chained, or transfo…

    …rmed
    
    Result.
    
    R=vbhasin,nnaze
    DELTA=271 (246 added, 0 deleted, 25 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6148
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2443 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    jdarpinian@google.com committed Jan 16, 2013
Commits on Jan 15, 2013
  1. allow {number} types in text nodes.

    I see a lot of people cast this, and i don't think there's
    a good reason to forbid it. wdyt?
    
    R=nnaze
    DELTA=7 (0 added, 0 deleted, 7 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6147
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2442 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    nicksantos@google.com committed Jan 15, 2013
  2. Update the documentation on sourceURL

    There should be no functional changes in this CL
    
    R=ssaviano
    DELTA=31 (15 added, 5 deleted, 11 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6146
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2441 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    nicksantos@google.com committed Jan 15, 2013
  3. Add isImplementedBy/addImplementation to

    goog.events.Listenable to be able to perform runtime check as
    to whether an instance is a listenable or not. Make
    goog.events.EventTarget call addImplementation.
    
    R=gboyer
    DELTA=76 (76 added, 0 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6140
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2440 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    chrishenry@google.com committed Jan 15, 2013
Commits on Jan 14, 2013
  1. Changed goog.events key type (listen/listenOnce return value,

    unlistenByKey param) to a typedef. It is currently a no-op
    (?number), but this allows for incremental cleanup of codebase
    to prepare for changing the type to an Object in the future.
    
    I spent a few hours looking at existing code
    and fixed most of the breakages (i.e. this is actually
    tractable). While doing that, I also tried to do collateral
    cleanups, such as using the key in goog.isNumber, changing
    default value from 0 to null, replacing if (key != 0) with if
    (key). I think there is a good chance that we can make
    goog.events return a key object in near future.
    
    R=gboyer,nicksantos
    DELTA=13 (8 added, 0 deleted, 5 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6139
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2439 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    chrishenry@google.com committed Jan 14, 2013
  2. Remove goog.provide for goog.ui.Palette.EventType. No usage afaict.

    R=nnaze,gboyer
    DELTA=1 (0 added, 1 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6138
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2438 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    chrishenry@google.com committed Jan 14, 2013
Commits on Jan 12, 2013
  1. Small change to goog.dom.classes so that setting the classname attrib…

    …ute goes through one method.
    
    Motivation: Currently this file does not work with SVG elements. To get or modify the classname attribute of SVG element, you must call getAttribute('class) and setAttribute('class', value) instead of accessing directly with .classname. I think another CL would make that change. But in the meantime with this change, the goog.dom.classes.set & .get functions can be overridden if necessary and then the rest of the functions in this file will continue to work.
    
    This is just one small step to get some feedback from the Closure team before proceeding further.
    
    R=closure-team,chrishenry,nnaze,vbhasin,nicksantos
    DELTA=4 (0 added, 0 deleted, 4 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6132
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2437 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    gshort@google.com committed Jan 12, 2013
  2. Introduces goog.ui.Component#getElementStrict. It differs from

    #getElement in that it first asserts that this.element_ is not
    null.
    
    This allows developers to get !Element in cases where they are
    sure that the component has been rendered/decorated.
    
    R=nnaze
    DELTA=15 (15 added, 0 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6131
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2436 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    chrishenry@google.com committed Jan 12, 2013
  3. fix a minor type warning

    R=chrishenry
    DELTA=3 (0 added, 0 deleted, 3 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6130
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2435 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    nicksantos@google.com committed Jan 12, 2013
Commits on Jan 11, 2013
  1. Added in events that fire when moving the highlight through the

    palette. This allows us to handle chaining palettes toghether
    where up/down/left/right will move between the palettes.
    
    
    Chris,
    
    Hoping you can take a look ath this or pass it on to someone who might make sense. THanks.
    
    R=chrishenry
    DELTA=69 (65 added, 1 deleted, 3 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6129
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2434 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    ajpalay@google.com committed Jan 11, 2013
  2. Exposes the .key() method on HTML5WebStorage instances.

    R=chrishenry
    DELTA=28 (28 added, 0 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6128
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2433 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    izaakr@google.com committed Jan 11, 2013
  3. Automated g4 rollback

    *** Reason for rollback ***
    
    breaks ff3.6 tests for unclear reasons
    
    *** Original change description ***
    
    Tweak the sourceUrl decision tree a bit, and update
    the comments on when this should be used.
    
    DELTA=35 (8 added, 18 deleted, 9 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6126
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2432 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    nicksantos@google.com committed Jan 11, 2013
  4. Add an optional parameter to the constructor of MouseWheelHandler to …

    …allow
    
    handling the event in capture phase.
    
    R=nicksantos
    DELTA=4 (2 added, 0 deleted, 2 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6125
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2431 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    baiming@google.com committed Jan 11, 2013
Commits on Jan 10, 2013
  1. Set type="text" for the <input> element in goog.ui.ComboBox.

    My use case is to be able to easily customize the style of all text inputs without modifying other input controls such as radio buttons. If the text attribute is not set, the CSS styles set in input[type=text] selectors are not applied.
    
    R=chrishenry,nnaze
    DELTA=12 (11 added, 0 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6114
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2430 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    pallosp@google.com committed Jan 10, 2013
  2. Tweak the sourceUrl decision tree a bit, and update

    the comments on when this should be used.
    
    R=ssaviano
    DELTA=32 (15 added, 5 deleted, 12 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6113
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2429 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    nicksantos@google.com committed Jan 10, 2013
  3. Rename more Closure _test.js files to end in tester.js to make room f…

    …or genjsdeps being update to include _test.js files in closure_test_suites.
    
    R=chrishenry
    DELTA=1007 (491 added, 491 deleted, 25 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6112
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2428 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    gdennis@google.com committed Jan 10, 2013
  4. Add goog.result.successfulResult/failedResult/canceledResult to the r…

    …esultutils library.
    
    R=chrishenry,vbhasin,nnaze
    DELTA=118 (118 added, 0 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6111
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2427 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    divye@google.com committed Jan 10, 2013
Commits on Jan 9, 2013
  1. Change a number of indexedDB functions to take primitive and array ty…

    …pes instead of !Object type for keys and * for values, in accordance with the documentation at https://developer.mozilla.org/en-US/docs/IndexedDB and http://www.w3.org/TR/IndexedDB/#key-construct
    
    This includes the final changes to the Index and Cursor classes, and corresponding extern changes
    
    This has the potential to introduce compiler type-check errors
    
    R=nicksantos
    DELTA=36 (0 added, 6 deleted, 30 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6110
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2426 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    jmoon@google.com committed Jan 9, 2013
  2. I'm renaming the files to end in _tests.js instead of _test.js so the…

    …y are not mistaken to be tests.
    
    R=chrishenry
    DELTA=727 (364 added, 330 deleted, 33 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6099
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2425 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    gdennis@google.com committed Jan 9, 2013
Commits on Jan 8, 2013
  1. Automated g4 rollback

    *** Reason for rollback ***
    
    Rolling the original change forward
    
    *** Original change description ***
    
    Automated g4 rollback
    
    *** Reason for rollback ***
    
    I can consistently make IE8 segfault after this change
    
    *** Original change description ***
    
    Generalize the the special handling of HR tags in
    goog.editor.range.placeCursorNextTo() to better handle IMG tags and
    other no-child-allowed Element nodes. This logic now takes effect
    for all browsers, rather than just IE/IE9.
    The the original behavior caused scrolling issues
    when inserting images or emoji in gmail, on IE.
    Also c
    
    ... description truncated by g4 rollback ...
    
    R=nicksantos
    DELTA=208 (167 added, 18 deleted, 23 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6098
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2424 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    jamisong@google.com committed Jan 8, 2013
  2. Make the demo for the PixelDensityMonitor listen to the correct event…

    … type.
    
    R=chrishenry
    DELTA=6 (2 added, 1 deleted, 3 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6096
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2423 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    mkaeser@google.com committed Jan 8, 2013
  3. Don't attempt to focus a disabled button. This causes the modal dialog

    to lose focus -- and the button isn't focused either.
    
    Tested:
    Manually on Chrome + unit test
    
    R=nicksantos
    DELTA=14 (13 added, 0 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6091
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2422 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    mariakhomenko@google.com committed Jan 8, 2013
Commits on Jan 7, 2013
  1. This particular CL contains the changes to KeyRange and the correspon…

    …ding changes to callers to prevent new compiler errors.
    
    This has the potential to introduce compiler type-check errors
    
    R=nicksantos
    DELTA=50 (0 added, 0 deleted, 50 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6090
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2421 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    jmoon@google.com committed Jan 7, 2013
  2. Adding support for showSeverityLevel to the HtmlFormatter.

    Severity Level is already handled in the TextFormatter. Seems like it was just an oversight in the original code.
    
    showSeverityLevel is false by default and I don't see any code in CodeSearch this will affect. But I need it for a console I'm working on.
    
    R=nicksantos
    DELTA=3 (3 added, 0 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6085
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2419 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    jonlesser@google.com committed Jan 7, 2013
Commits on Jan 6, 2013
  1. Change goog.Timer to look for timer methods on goog.global instead of…

    … goog.global['window'].
    
    Using goog.global['window'] throws an exception if the domain is escalated after the window reference is saved. 
    
    R=nicksantos
    DELTA=15 (0 added, 0 deleted, 15 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6084
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2418 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    asweintraub@google.com committed Jan 6, 2013
Commits on Jan 5, 2013
  1. [XhrIo] Expose the responseBody property of the XHR object, which is …

    …defined in IE. IE 9 can only access binary data from an XHR via this property.
    
    R=brenneman
    DELTA=53 (44 added, 3 deleted, 6 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6083
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2417 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    peyman@google.com committed Jan 5, 2013
  2. Adds a pixel density monitor to the closure labs that can be queried …

    …for the current pixel density of a window and dispatches events when it changes.
    
    The pixel densities are mapped to two different modes:
    - NORMAL for older screens with a ratio of less than 1.5.
    - HIGH for modern screens with a bigger ratio.
    
    Tested on Chrome and FF > 18.
    
    R=chrishenry
    DELTA=531 (513 added, 18 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6082
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2416 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    mkaeser@google.com committed Jan 5, 2013
Commits on Jan 4, 2013
  1. Allow for exceptions thrown in goog.storage to be processed by an ext…

    …ernal error handler.
    
    This allows for a centralized exception logging when setting/getting values, without having to wrap each call site with a try/catch block.
    
    R=azzie,chrishenry
    DELTA=227 (227 added, 0 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6081
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2415 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    ruilopes@google.com committed Jan 4, 2013
  2. Subset of original which updates IndexedDB's ObjectStore to properly …

    …take * for values and require KeyType for keys.
    
    This has the potential to introduce compiler type-check errors
    
    R=nicksantos,arthurhsu
    DELTA=19 (0 added, 0 deleted, 19 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=6069
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2414 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    jmoon@google.com committed Jan 4, 2013