Permalink
Commits on Mar 22, 2012
  1. Merge pull request #5552 from lest/patch-3

    tenderlove committed Mar 22, 2012
    deprecate Proc#bind that can cause symbol memory leak
  2. Merge pull request #5540 from mhfs/another_blank_line_fix

    drogus committed Mar 22, 2012
    Avoid another blank line in generated migration and remove assertion as per @spastorino request
Commits on Mar 21, 2012
  1. evented subscribers work

    tenderlove committed Mar 21, 2012
  2. Deprecate eager-evaluated scopes.

    jonleighton committed Mar 21, 2012
    Don't use this:
    
        scope :red, where(color: 'red')
        default_scope where(color: 'red')
    
    Use this:
    
        scope :red, -> { where(color: 'red') }
        default_scope { where(color: 'red') }
    
    The former has numerous issues. It is a common newbie gotcha to do
    the following:
    
        scope :recent, where(published_at: Time.now - 2.weeks)
    
    Or a more subtle variant:
    
        scope :recent, -> { where(published_at: Time.now - 2.weeks) }
        scope :recent_red, recent.where(color: 'red')
    
    Eager scopes are also very complex to implement within Active
    Record, and there are still bugs. For example, the following does
    not do what you expect:
    
        scope :remove_conditions, except(:where)
        where(...).remove_conditions # => still has conditions
  3. Remove valid_scope_name? check - use ruby

    jonleighton committed Mar 21, 2012
    scope is syntactic sugar for defining a class method. Ruby allows
    redefining methods but emits a warning when run with -w. So let's
    not implement our own logic for this. Users should run with -w if they
    want to be warned about redefined methods.
  4. no need for cast

    jonleighton committed Mar 21, 2012
  5. no need for lvar

    jonleighton committed Mar 21, 2012
  6. Merge pull request #5532 from mhfs/migration_blank_line

    josevalim committed Mar 21, 2012
    Remove blank line from generated migration
  7. Merge pull request #5522 from travisjeffery/fix_migration_generator_a…

    josevalim committed Mar 21, 2012
    …dding_removing_index
    
    Fix adding/removing field's index when generating migration
  8. Generate Migration Thats Adds Removed Index

    travisjeffery committed Mar 21, 2012
    When generating a migration that removes a field with an index, the down
    will add both the field and its index.
Commits on Mar 20, 2012
  1. We dont need to merge in the parameters as thats all being reset by t…

    dhh committed Mar 20, 2012
    …he rack headers (and its causing problems for Strong Parameters attempt of wrapping request.parameters because it will change in testing)
  2. Merge pull request #5524 from kennyj/add_missing_require

    fxn committed Mar 20, 2012
    Add missing require
  3. Add missing require

    kennyj committed Mar 20, 2012
Commits on Mar 19, 2012
  1. Merge pull request #5515 from rafaelfranca/remove-exclude

    josevalim committed Mar 19, 2012
    Remove exclude option from ActionDispatch::SSL and fix secure cookies
  2. Merge pull request #5503 from jeyb/leap_day_time_date_time_selector

    pixeltrix committed Mar 19, 2012
    Fixes issue #5222: DateTimeSelector builds invalid dates on leap days
  3. Merge pull request #5507 from sandeepravi/warning_fixes

    fxn committed Mar 19, 2012
    changed all.map to pluck
  4. Merge pull request #5508 from FND/tagged_logger_shortcut

    josevalim committed Mar 19, 2012
    Provide access to logger instance within TaggedLogging blocks