Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Mar 22, 2012
  1. @tenderlove
  2. @tenderlove

    Merge pull request #5552 from lest/patch-3

    tenderlove authored
    deprecate Proc#bind that can cause symbol memory leak
  3. @lest
  4. @drogus

    Merge pull request #5540 from mhfs/another_blank_line_fix

    drogus authored
    Avoid another blank line in generated migration and remove assertion as per @spastorino request
Commits on Mar 21, 2012
  1. @tenderlove
  2. @tenderlove
  3. @tenderlove

    evented subscribers work

    tenderlove authored
  4. @tenderlove
  5. @tenderlove
  6. @mhfs
  7. @jonleighton

    Deprecate eager-evaluated scopes.

    jonleighton authored
    Don't use this:
    
        scope :red, where(color: 'red')
        default_scope where(color: 'red')
    
    Use this:
    
        scope :red, -> { where(color: 'red') }
        default_scope { where(color: 'red') }
    
    The former has numerous issues. It is a common newbie gotcha to do
    the following:
    
        scope :recent, where(published_at: Time.now - 2.weeks)
    
    Or a more subtle variant:
    
        scope :recent, -> { where(published_at: Time.now - 2.weeks) }
        scope :recent_red, recent.where(color: 'red')
    
    Eager scopes are also very complex to implement within Active
    Record, and there are still bugs. For example, the following does
    not do what you expect:
    
        scope :remove_conditions, except(:where)
        where(...).remove_conditions # => still has conditions
  8. @jonleighton
  9. @jonleighton

    Remove valid_scope_name? check - use ruby

    jonleighton authored
    scope is syntactic sugar for defining a class method. Ruby allows
    redefining methods but emits a warning when run with -w. So let's
    not implement our own logic for this. Users should run with -w if they
    want to be warned about redefined methods.
  10. @jonleighton

    no need for cast

    jonleighton authored
  11. @jonleighton

    no need for lvar

    jonleighton authored
  12. @tenderlove
  13. @josevalim

    Merge pull request #5532 from mhfs/migration_blank_line

    josevalim authored
    Remove blank line from generated migration
  14. @josevalim

    Merge pull request #5522 from travisjeffery/fix_migration_generator_a…

    josevalim authored
    …dding_removing_index
    
    Fix adding/removing field's index when generating migration
  15. @travisjeffery

    Generate Migration Thats Adds Removed Index

    travisjeffery authored
    When generating a migration that removes a field with an index, the down
    will add both the field and its index.
  16. @mhfs
Commits on Mar 20, 2012
  1. @dhh

    We dont need to merge in the parameters as thats all being reset by t…

    dhh authored
    …he rack headers (and its causing problems for Strong Parameters attempt of wrapping request.parameters because it will change in testing)
  2. @tenderlove
  3. @tenderlove
  4. @tenderlove
  5. @vijaydev
  6. @fxn

    Merge pull request #5524 from kennyj/add_missing_require

    fxn authored
    Add missing require
  7. @kennyj

    Add missing require

    kennyj authored
Commits on Mar 19, 2012
  1. @josevalim

    Merge pull request #5515 from rafaelfranca/remove-exclude

    josevalim authored
    Remove exclude option from ActionDispatch::SSL and fix secure cookies
  2. @rafaelfranca
  3. @rafaelfranca
  4. @pixeltrix

    Merge pull request #5503 from jeyb/leap_day_time_date_time_selector

    pixeltrix authored
    Fixes issue #5222: DateTimeSelector builds invalid dates on leap days
  5. @vijaydev
  6. @sandeepr-sourcebits
  7. @fxn

    Merge pull request #5507 from sandeepravi/warning_fixes

    fxn authored
    changed all.map to pluck
  8. @josevalim

    Merge pull request #5508 from FND/tagged_logger_shortcut

    josevalim authored
    Provide access to logger instance within TaggedLogging blocks
Something went wrong with that request. Please try again.