feat: android tv #598
Merged
feat: android tv #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # gradle/libs.versions.toml
# Conflicts: # .github/workflows/build.yaml # gradle/libs.versions.toml
# Conflicts: # gradle/libs.versions.toml
Also fix lint issue on HomeScreen
kotlin 1.9.20 -> 1.9.21 ksp 1.9.20-1.0.14 -> 1.9.21-1.0.15 compose-compiler 1.5.5 -> 1.5.6
compose-compiler 1.5.6 -> 1.5.7
New sub settings screen with different layout Settings detail select card to select an option
Courtesy of Android TV JetStreamCompose sample
Need to add ability to disable track type
|
this looks beautiful. |
|
🎉🎉 |
|
@drizzt09 I guess it still far away, I tried the debug build in chromecast with Google tv, the playback is not working, also some minor navigation issues. |
|
I compiled and installed tv-libre-armeabi-v7a-debug.apk on our Sony Bravia running android 10. |
|
The TV UI looks really good :) Only thing is that the posters should maybe be displayed when viewing a single movie/show and not just the background image. |
ghost
pushed a commit
to pruthvi-21/findroid
that referenced
this pull request
Jul 22, 2024
* Add AddServerScreen * Upgrade androidx-compose-material3 and androidx-compose-ui to alpha * Add DiscoveredServerComponent * Show discovered servers * Add navigation using compose-destinations * Implement Loginscreen * Start of HomeScreen * Use coil for home screen images and update layout with spacers * Select correct startRoute based on conditions * Upgrade compose material3 to 1.1.0-alpha05 * Add series title, max 1 line, padding * Upgrade dependencies * Switch to TvLazyColumn and TvLazyRow * Add header to `HomeScreen` * Add progress bar to Continue watching items * Limit the number of lines under Movie or Show and use correct episode text * chore: run ktlintFormat * ci: assemble tv * feat: `LibraryScreen` * fix: update to reworked items system * chore(deps): update androidx-paging-compose and compose-destination Also fix lint issue on HomeScreen * feat: start using androidx.material3 composables * feat: add coil svg * feat: experimenting with cards * lint: fix linting issues * feat: server select screen * build: upgrade dependencies * lint: run ktlintFormat * feat(ServerSelectScreen): add "No servers found" text * feat: update AddServerScreen * feat: implement `UiText.asString()` composable * lint: run ktlintFormat * refactor(phone): remove livedata from `ServerSelectScreen` * feat: add `UserSelectScreen` * feat(UserSelectScreen): load user's profile picture * feat: update LoginScreen * feat: update progress indicator on `AddServerScreen` * fix: change color of `ServerComponent` * style(ServerSelect): use material typography * chore: update ktlint config in build.gradle * style: use material typography * refactor: move home screen to separate layout function so it can be previewed - Introduce dummy items - Fix `UiText.asString()` composable * refactor: preview `LibraryScreen` * refactor: preview `ServerSelectScreen` * refactor: preview `AddServerScreen` * refactor: preview `UserSelectScreen` * refactor: preview `LoginScreen` * lint: run ktlintFormat * feat: switch servers * feat: main screen tabs navigation * feat: add Live TV tab (not shown for now) * chore: remove libraries from `HomeViewModel` * chore: change colors of selected tab * feat: new item card component * chore: remove `HomeItem.Libraries` * style: update spacing * feat: add findroid icon and profile button on main screen * style(main): add gradient background * fix: use "latest" + library name in home screen * fix: navigate from LoginScreen and UserSelectScreen to MainScreen * style: update tab colors * fix: remove reference to `HomeItem.Libraries` from `ViewListAdapter` * chore: update kotlin compiler to 1.5.0 * feat: add horizontal item card variant * feat: `LibrariesScreen` * feat: `LibraryScreen` * fix(`LibraryScreen`): remove hardcoded library name * feat: `MovieScreen` * feat(`MovieScreen`): Make trailer button work Also hide the button when there is no trailer * refactor(`MovieScreen`): move click logic out of layout * refactor: create `FindroidImages` which holds all image uris * build: upgrade androidx.tv to 1.0.0-alpha08 * chore: update compose libraries * chore: update compose compiler to 1.5.1 * fix(ItemCard): only show progress when horizontal * refactor: clean build.gradle.kts * build: up minSdk to 28 and targetSdk to 34 * refactor: use spacings to provide paddings (jarnedemeulemeester#443) * feat: add Spacings in MaterialTheme * style: use MaterialTheme.spacings in layouts Using sizes in Spacer & padding & PaddingValues to standardize it. * fix: linting issues and a few paddings * feat: use spacings in `LibraryScreen` * feat: use spacings in `MovieScreen` * fix: missing trailing comma * refactor: replace hardcoded spacer in ItemCard with spacing --------- Co-authored-by: Jarne Demeulemeester <jarnedemeulemeester@gmail.com> * build: migrate to ksp and upgrade compose compiler * build: upgrade compose libraries * fix: align with main codebase * chore: update agp to 8.1.3 * chore: update ksp and compose-destinations ksp 1.9.10-1.0.13 -> 1.9.20-1.0.14 compose-destinations 1.9.51 -> 1.9.54 * refactor(UserSelectViewModel): use channel for events * feat: basic video player First implementation of the video player. Uses the basic player view with no custom layout. Only media keys are passed to the PlayerView. * feat: show screen Still a work in progress * fix: make player background black * fix(player): keep screen on * feat: add border around focused tab * lint: run ktlintFormat * feat: focus improvements * feat: logo for main screen * fix: remember tab position * feat: add loading indicator to main screen And fix home and libraries screen list refresh on navigating back * feat: add seasons to show screen * feat: add season screen * feat: add progress badge * chore(deps) update dependencies android-plugin 8.1.3 -> 8.1.4 androidx-activity 1.8.0 -> 1.8.1 androidx-media3 1.1.1 -> 1.2.0 coil 2.4.0 -> 2.5.0 kotlinx-serialization 1.6.0 -> 1.6.1 * ci: upload tv artifacts and don't build universal apks * chore: get rid of deprecated android.defaults.buildfeatures.buildconfig * build: upgrade dependencies android-plugin 8.1.4 -> 8.2.0 androidx-room 2.6.0 -> 2.6.1 androidx-work 2.8.1 -> 2.9.0 jellyfin 1.4.5 -> 1.4.6 compose compiler 1.5.4 -> 1.5.5 * fix: workManagerConfiguration is now a property * feat: add profile picture to main screen * feat: start of settings screen * refactor: base tv theme on normal compose material theme * chore(deps): update kotlin to 1.9.21 kotlin 1.9.20 -> 1.9.21 ksp 1.9.20-1.0.14 -> 1.9.21-1.0.15 compose-compiler 1.5.5 -> 1.5.6 * feat(settings): add categories and pop backstack when navigating to main screen * feat(settings): nested settings and switch setting * feat(settings): settings select component * feat(settings): icons for cache and about * feat(settings): add option to toggle mpv player * feat(settings): move preference value logic to viewmodel * feat(settings): add dependencies * chore: update compose compiler compose-compiler 1.5.6 -> 1.5.7 * feat(settings): add settings detail select card New sub settings screen with different layout Settings detail select card to select an option * feat: play episode from home screen * feat(player): basic custom overlay Courtesy of Android TV JetStreamCompose sample * feat(player): add track selection dialog * feat(player): add media session and clean up dpad events * refactor(mpv): implement track selection via TrackSelectionParameters Need to add ability to disable track type * feat: implement watched and favorite buttons * refactor: remove unused PreferenceType enum ---------
|
great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's finally time to merge the Android TV code back to the main branch.
There are still some things that need to be implemented. But these will come in smaller separate PRs.
Here is a quick overview of all the features currently implemented:
Home
The home screen displays the "Continue Watching", "Next Up" and latest items of each library with progress indicators.
At the top are three tabs. Of these three only search has not been implemented yet.
Settings are accessed using the profile button at the top right.
Libraries
Shows a list of all the libraries the user has access to. Currently does not implement a way to sort or filter.
Library
Displays a list of movies or shows with watched indicators. Does not have a way to sort or filter yet.
Movie
Displays all the expected information except for metadata chips and cast & crew.
You can play the movie, watch the trailer, mark as played or add to favorites.
Show
Same as the movie screen but also lists the seasons.
Season
Lists all episodes in the season with progress indicators and watched status.
Does not have the ability to sort or filter yet.
I will probably also add a feature to automatically scroll to the next up episode.
Player
Play and pause the media, change audio or subtitle tracks and seeking are all implemented.
There is currently no way to completely disable the audio or subtitles.
Skip intro and trickplay will also be added later.
Settings
Currently there are only a few settings available.
Servers
Lists all configured servers.
Discovered server are shown in the same list.
Add a server by manually typing in the server address.
Users
Lists all configured and public users.
Log in using username / password or via Quick Connect (not shown in screenshot because the demo server does not have Quick Connect enabled).
Closes #23
Closes #534