New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown code snippet "disappear" (collapse) unexpectedly upon clicking #97

Closed
Atlas7 opened this Issue Nov 23, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@Atlas7
Contributor

Atlas7 commented Nov 23, 2017

For some reason, if you have a blog post with a markdown code snippet (created using the triple backtick method), and when you click on that code snippet, it for some reason "disappear" ( (or "collapse" in CSS terms)

Here is a demo - try click on the code snippet and you will see. This is my GitHub repo

I've also just git clone the Jalpc repository from scratch, create a blog post (with a code snippet). Same outcome.

Anybody have similar issue / know how to solve this? (I have no idea how to solve this currently and am quite stuck!)

@Atlas7

This comment has been minimized.

Contributor

Atlas7 commented Nov 23, 2017

With the help of @keram https://github.com/keram we've hunted down the bug.

Line 6-10 of the this js file needs commented out / removed.

In addition, for the time being I manually remove the corresponding lines in the min files here. i.e. blog-20170906.min.js.

I've fixed this problem for my own blog for now. Happy to work on a patch and submit a pull request if this is indeed an issue?

@jarrekk

This comment has been minimized.

Owner

jarrekk commented Dec 4, 2017

@Atlas7
Thanks for this issue and tracking bug with @keram !
It's fine to create a PR for this issue, nice job! :)

@jarrekk jarrekk added the bug label Dec 4, 2017

@jarrekk jarrekk self-assigned this Dec 4, 2017

jarrekk added a commit that referenced this issue Dec 21, 2017

fix bug #97
need run build

@jarrekk jarrekk closed this Dec 21, 2017

@Atlas7

This comment has been minimized.

Contributor

Atlas7 commented Dec 21, 2017

ah apologies for the delay on this (and I'm glad you've got it fixed nevertheless). Thank you!

@Atlas7

This comment has been minimized.

Contributor

Atlas7 commented Dec 21, 2017

Re-opening this thread. Turns out the minified javascript needs updating too. See PR #102.

shabbir-hasan added a commit to shabbir-hasan/shabbir-hasan.github.io that referenced this issue Dec 21, 2017

isooo added a commit to isooo/isooo.github.io that referenced this issue Jan 9, 2018

modify bug
==> Markdown code snippet "disappear" (collapse) unexpectedly upon clicking(jarrekk/Jalpc#97)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment