Make bestline work in rc #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jart
approved these changes
Oct 20, 2024
Owner
jart
left a comment
jart
left a comment
There was a problem hiding this comment.
Sorry about the latency getting back to you. It's really exciting that you're using bestline in rc. This requires an API change. It should be minimally disruptive though. I personally don't mind adding an additional parameter to my completion callbacks. So if your project needs this, then I'm happy to approve. Could you sync this PR to head so I can click merge? Thanks!
Contributor
Author
|
Thanks for your review! I have rebased this branch and resolved all conflicts (only whitespace changes). Update: I have squashed the first and fourth commit into one. |
The cursor position (pos) is important to know if you want to use bestline in a shell. Example: When the cursor is at the end of the first word, you need command completions. When the cursor is that the end of a word beginning with `$`, you need variable completions.
jart
approved these changes
Oct 22, 2024
Owner
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created a pull request to rakitzis/rc to integrate bestline: Support bestline for line editing #100.
Unfortunately, bestline isn't ideal to be used in rc as it is now:
To be useful in a shell, it's necessary to pass the cursor position when calling the
completefunction because the user might want to complete any word (token) in the current command line. I'm aware that this is a breaking change. But it might make bestline more suitable for other projects, too.This pull request also adds a new
libbestline.sotarget to theMakefilebecause thercmaintainers prefer linking against a shared library instead of copying the current state of a line editing library (at least they did in the past: rakitzis/rc#5 (comment)).