Repository navigation
Ip6 getifaddrs - #1415
Merged
Merged
Ip6 getifaddrs#1415
Conversation
jart
requested changes
May 21, 2025
jart
left a comment
jart
left a comment
Owner
There was a problem hiding this comment.
Looks good. Could you sync to head for a cachestat CI fix so we can verify tests work? Also could you send the email mentioned in CONTRIBUTING.md? Thanks!
Netmask address was used to display the network broadcast address.
Reading the `/proc/net/if_inet6` pseudo-file allows parsing IPv6 addresses, which are now included in the list returned by `getifaddrs()`. This patch: - Adds support for AF_INET6 entries by reading from the procfs - Parses scope, prefix length, and flags from the if_inet6 format - Constructs `sockaddr_in6` and attaches them to `ifaddrs` structs - Maintains compatibility with existing AF_INET handling - Adds `IfAddr6` and supporting structures to represent IPv6 info
Contributor
Author
|
Thanks for considering this change, I already did the CCA in 2022 see #641 (review) |
jart
approved these changes
May 21, 2025
jart
left a comment
jart
left a comment
Owner
There was a problem hiding this comment.
Right you are. Welcome back :) LGTM
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github discussion: #1412
This is Linux only, I don't known how to implement this for other platforms, any help is welcome.
Reading the
/proc/net/if_inet6pseudo-file allows parsing IPv6 addresses,which are now included in the list returned by
getifaddrs().This patch:
sockaddr_in6and attaches them toifaddrsstructsIfAddr6and supporting structures to represent IPv6 info