setlocale: Add fake support for locale="")#546
Merged
jart merged 1 commit intojart:masterfrom Aug 18, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setlocale( int category, "");is supposed to set the category or all categories in the case of the categoryLC_ALLto the values specified in the environment.Actually querying the environment would be unlikely to be helpful as we only support the C or POSIX locales, so why not fake it.
Some programs such as perl call
setlocale( LC_ALL, "");, at startup expecting it to be able to set the locale from the environment and prints an error if it fails.We could instead of this patch, actually setup the environment with
LC_*="C"and changesetlocaleto query it, but so far this seems to work and is simpler.