Skip to content

Double-width icons can cause duplicated first characters in the filename on macOS - #1711

Merged
jarun merged 1 commit into
jarun:masterfrom
quantonganh:dup-first-char-macOS
Aug 20, 2023
Merged

Double-width icons can cause duplicated first characters in the filename on macOS#1711
jarun merged 1 commit into
jarun:masterfrom
quantonganh:dup-first-char-macOS

Conversation

@quantonganh

@quantonganh quantonganh commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

Fix #1692

@quantonganh

quantonganh commented Aug 9, 2023

Copy link
Copy Markdown
Contributor Author

Why this failed?

Either git or ssh (required by git to clone through SSH) is not installed in the image. Falling back to CircleCI's native git client but the behavior may be different from official git. If this is an issue, please use an image that has official git and ssh installed.
Cloning git repository
Enumerating objects: 17975, done.
Counting objects: 100% (164/164), done.
Compressing objects: 100% (80/80), done.
Total 17975 (delta 88), reused 135 (delta 81), pack-reused 17811

error fetching: couldn't find remote ref "refs/pull/1711/head"

@jarun

jarun commented Aug 9, 2023

Copy link
Copy Markdown
Owner

Can you please make the change macOS-specific?

@quantonganh
quantonganh force-pushed the dup-first-char-macOS branch from 7b13daa to f37bcb5 Compare August 9, 2023 13:24
@quantonganh quantonganh changed the title Clear the entire line and refresh the screen before calling printent Double-width icons can cause duplicated first characters in the filename on macOS Aug 9, 2023
@quantonganh

quantonganh commented Aug 9, 2023

Copy link
Copy Markdown
Contributor Author

Can you please make the change macOS-specific?

I did it, please review.

N-R-K
N-R-K reviewed Aug 9, 2023
View reviewed changes
Comment thread src/nnn.c Outdated
N-R-K
N-R-K reviewed Aug 10, 2023
View reviewed changes
Comment thread src/nnn.c Outdated
@quantonganh
quantonganh force-pushed the dup-first-char-macOS branch from f37bcb5 to d220c50 Compare August 10, 2023 23:54
jarun
jarun requested changes Aug 15, 2023
View reviewed changes
Comment thread src/nnn.c
@jarun
jarun merged commit 1ba8582 into jarun:master Aug 20, 2023
@jarun

jarun commented Aug 20, 2023

Copy link
Copy Markdown
Owner

Thank you!

@github-actions github-actions Bot locked and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jarun jarun jarun requested changes
@N-R-K N-R-K N-R-K approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

O_NERD and O_EMOJI creates duplicate letters in filename

3 participants

@quantonganh @jarun @N-R-K