New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons in Toolbar not working in Python 2.X #192

Closed
jarvisteach opened this Issue Jul 23, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@jarvisteach
Owner

jarvisteach commented Jul 23, 2017

When running the showcase app, no icons show in the toolbar, when run under python 2.7.

This is because they are PNGs, and the incorporated library struggles to work under python 2.

@jarvisteach jarvisteach added the bug label Jul 23, 2017

@jarvisteach jarvisteach added this to the 0.07 milestone Jul 23, 2017

@jarvisteach jarvisteach self-assigned this Jul 23, 2017

@jarvisteach

This comment has been minimized.

Show comment
Hide comment
@jarvisteach

jarvisteach Jul 23, 2017

Owner

The issue seems to revolve around two built-in functions:

  • array.array - problems with unicode support
  • map - not returning an iterable

A couple of fixes need to be incorporated:

  • Ensure all types are cast as strings when creating arrays
  • Ensure when checking datatypes are strings, also look for unicode
  • If running under python 2, user itertools instead of map
Owner

jarvisteach commented Jul 23, 2017

The issue seems to revolve around two built-in functions:

  • array.array - problems with unicode support
  • map - not returning an iterable

A couple of fixes need to be incorporated:

  • Ensure all types are cast as strings when creating arrays
  • Ensure when checking datatypes are strings, also look for unicode
  • If running under python 2, user itertools instead of map

jarvisteach added a commit that referenced this issue Jul 23, 2017

Fixes for png in 2.7 #192
Fixes to array, map & str checking

jarvisteach added a commit that referenced this issue Jul 23, 2017

Docs in #192
Update to docs
Also, removed star #190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment