New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scrollbars optional on Grid #200

Closed
jarvisteach opened this Issue Aug 2, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@jarvisteach
Owner

jarvisteach commented Aug 2, 2017

Split form #152

Scrollbars aren't always desirable/necessary on Grid widget.
Need to look into AutoScrollBars, or setting as a parameter.

@jarvisteach jarvisteach added this to the 0.08 milestone Aug 2, 2017

jarvisteach added a commit that referenced this issue Aug 9, 2017

@jarvisteach

This comment has been minimized.

Show comment
Hide comment
@jarvisteach

jarvisteach Aug 9, 2017

Owner

AutoScrollBar works fine, but mouse scrolling is broken.

Scrolling should only be bound when the mouse is over the grid, and shouldn't scroll when there are no scrollbars - see ScrollPane container for guidance.

Owner

jarvisteach commented Aug 9, 2017

AutoScrollBar works fine, but mouse scrolling is broken.

Scrolling should only be bound when the mouse is over the grid, and shouldn't scroll when there are no scrollbars - see ScrollPane container for guidance.

jarvisteach added a commit that referenced this issue Aug 9, 2017

Switched SimpleGrid to a ScrollPane (#200)
SimpleGrid now extends ScrollPane.

This allows it to inherit all of the scrolling capabilities.

ScrollPane has been updated to use AutoScrollbars and prevent scrolling when Scrollbars are hidden.

It's also been changed so that keyboard scrolling only works when the mouse is over it.

jarvisteach added a commit that referenced this issue Aug 9, 2017

@jarvisteach jarvisteach closed this Aug 9, 2017

jarvisteach added a commit that referenced this issue Aug 9, 2017

jarvisteach added a commit that referenced this issue Aug 10, 2017

Fixed issue with scrolling (#200)
Also updated scroll testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment