New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid Size #255

Closed
keithterrill opened this Issue Oct 1, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@keithterrill

keithterrill commented Oct 1, 2017

How do we define the size of the Grid?

app.addGrid("tbl",[["H1","H2","H3"],["1","2","3"]],action=press,addRow=press)
app.setGridWidth("tbl",800)
app.setGridHeight("tbl",800)

I thought the setGridWidth and setGridHeight would do this.

PS: I find it slightly confusing to call this Grid when the geometry manager is grid.

@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Oct 1, 2017

Currently, these 2 config options are getting ignored, I'll get them included.

True, there is a bit of a conflict - but the majority of the audience won't know what geometry managers are, and those that do, can probably handle it :) One day, I have an alternative grid to implement, and I'll probably bring in some kind of simpler waffle class - that just gives a grid of labels, a bit like the micro:bit widget...

@jarvisteach jarvisteach added this to the 0.90 milestone Oct 1, 2017

@jarvisteach jarvisteach self-assigned this Oct 1, 2017

jarvisteach added a commit that referenced this issue Oct 1, 2017

@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Oct 1, 2017

Had a quick look at this - interesting issue with config implementation...

If a subClass calls config on the superClass, and the superClass also calls config on its super - we get stuck in a recursive loop.

In this scenario:

  • SimpleGrid isa ScrollPane isa Frame
  • When super.config() is called in SimpleGrid, it passes self as a parameter
  • When super.config() is called in ScrollPane, it uses the self parameter, which was the SimpleGrid - thereby calling the same config() function

Might need to look at how super.config() is being used, and fix it for extended inheritance trees...

@keithterrill

This comment has been minimized.

keithterrill commented Oct 1, 2017

Regards GRID, Waffle Class. At this time I would consider naming it "Table". That would reflect the 2 dimensional aspect of the Grid, keep in line with other systems (such as dBASE and all of its relatives, example: Visual Foxpro), and be something that is not already named in appJar.

@jarvisteach jarvisteach referenced this issue Oct 14, 2017

Open

Table Features Backlog #266

10 of 21 tasks complete
@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Oct 14, 2017

Closing this, see #266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment