New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callback? #286

Closed
mpmc opened this Issue Oct 26, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@mpmc
Contributor

mpmc commented Oct 26, 2017

For example instead of just calling a thread & queuing from inside you could call.

app.callback(thread_method, callback_method, args, kwargs)

This would trigger thread_method (with the passed (kw)args) in a new thread, once that completes call (or queue?) the callback that handles the result from thread_method.

@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Oct 26, 2017

This sound like a great idea! A good opportunity for submitting a PR?

@jarvisteach jarvisteach added this to the 1.0 milestone Oct 26, 2017

jarvisteach added a commit that referenced this issue Nov 29, 2017

@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Nov 29, 2017

@mpmc I've merged in the pull request, thanks for that.

Fancy writing some documentation?

The documentation is all in markdown, and the page that needs modifying is: docs/mkdocs/docs/pythonThreads.md

I've added a stub at the end of the page, you can modify that directly, or include something here and I'll add it in...

@jarvisteach jarvisteach modified the milestones: 1.0, 0.90 Nov 29, 2017

jarvisteach added a commit that referenced this issue Dec 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment