New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogs in subWindows break mainWindow #288

Closed
jarvisteach opened this Issue Nov 7, 2017 · 5 comments

Comments

Projects
None yet
1 participant
@jarvisteach
Owner

jarvisteach commented Nov 7, 2017

If the main window is hidden, and the user is interacting with a subWindow, and a dialog is shown. On closing the dialog, a weird empty window appears....

@jarvisteach jarvisteach added the bug label Nov 7, 2017

jarvisteach added a commit that referenced this issue Nov 7, 2017

@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Nov 7, 2017

After initial investigation, it seems the main window is being shown. But no widgets have yet been added to it.

If the GUI starts with the main window, then launches a sub and hides the main. The same symptom occurs, but the main does have its widgets.

@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Nov 7, 2017

Additional things to investigate:

  1. Want to set a stop function on the subWindow, that kills everything. But, shouldn't call stop function when the subWindow is hidden...
  2. Want to be able to manually hide main and show sub before calling go()

@jarvisteach jarvisteach added this to the 0.90 milestone Nov 7, 2017

@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Nov 8, 2017

  1. was resolved in #278
  2. will require storing a hidden status, and applying it...
@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Nov 8, 2017

So - after showing popups, appJar is calling __bringToFront() to ensure the window gets back focus. But, if the window isn't shown, this brings it back.

Ideally, dialogs should know their parent, and then call __bringToFront() on that.
But, they don't. The user has the option to set a parent, but it's not forced.

So, if parent is set - then we'll call __bringToFront() on that.
Otherwise, call it on the topLevel, if a boolean flag is set.

This same flag can be used in go() to determine if we should show the main...

jarvisteach added a commit that referenced this issue Nov 9, 2017

Fixed popup issues #288
New flag `displayed` to allow hide/show sub windows & popups to work
correctly in subWindows.

Also, extra parameter on entries - `change`
@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Nov 9, 2017

Resolved - made call to __bringToFront() conditional.

@jarvisteach jarvisteach closed this Nov 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment