New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Entries #292

Closed
jarvisteach opened this Issue Nov 7, 2017 · 6 comments

Comments

Projects
None yet
1 participant
@jarvisteach
Owner

jarvisteach commented Nov 7, 2017

Secret entries show default as stars

@jarvisteach jarvisteach added the bug label Nov 7, 2017

@jarvisteach jarvisteach added this to the 0.90 milestone Nov 7, 2017

@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Nov 9, 2017

Also - if you set a default on a directory/file entry it is temporarily replaced, the first time the widget is shown.

@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Nov 9, 2017

Also, setting limits still causes change events when the limit is hit.

@jarvisteach jarvisteach changed the title from Secret entries show default as stars to Issues with Entries Nov 9, 2017

@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Nov 9, 2017

Also - see #252 - labelValidationEntries have issues :(

jarvisteach added a commit that referenced this issue Nov 10, 2017

Entry refactor
Start of refactoring for #235.

All `.add*Entry()` functions now call `.__entryMaker()`

That in turn calls the relevant `.build*Entry()` function, as well as
making a labelFrame if required.

The `.entry()` function now also calls `.__entryMaker()`

Also, resolved some entry issues #292:
* secretEntries now support defaults
* file/directory entries better support setting defaults

Updated tests & docs
@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Nov 10, 2017

Issue with secret entries resolved.
Function existed to change the default - the fact that I didn't use it says something!
Will deprecate that, and make setDefault the only option.

Will leave issue with change call on limited entries for now - raise a new issue.
And have added an error message to warn label validation entries not allowed.

jarvisteach added a commit that referenced this issue Nov 10, 2017

Updates to setDefault #292
Deprecated updateDefault - setDefault now does both.

jarvisteach added a commit that referenced this issue Nov 10, 2017

@jarvisteach jarvisteach reopened this Nov 11, 2017

@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Nov 11, 2017

Validation entries change the colour of default text - should stay the same

Also, can't access behind label/button on validation/file entries to change the colour.

jarvisteach added a commit that referenced this issue Nov 15, 2017

Validation/Default issues resolved #292
Setting status of validation entry doesn;t change colour of default text
@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Nov 15, 2017

Closing this issue. Will raise BG image as separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment