New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not happy with layout #301

Closed
jarvisteach opened this Issue Nov 23, 2017 · 4 comments

Comments

Projects
None yet
1 participant
@jarvisteach
Owner

jarvisteach commented Nov 23, 2017

When adding widgets, using the auto row option, adding one widget manually, earlier in the sequence breaks things...

jarvisteach added a commit that referenced this issue Nov 23, 2017

@jarvisteach jarvisteach added this to the 0.90 milestone Nov 26, 2017

@jarvisteach jarvisteach modified the milestones: 0.90, 1.0 Dec 10, 2017

@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Feb 13, 2018

Want to be able to access more row details when setting:

  • If set to previous then should reuse the one already configured (using getRow)
  • If set to new then should generate a new row and use that.
@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Feb 13, 2018

This already sort of exists -

  • new is generated by setting to -1
  • previous is generated by setting to None
@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Feb 13, 2018

Outstanding issue is what to do when user manually changes the row.

If user has been adding widgets, with no row parameter, then appJar keeps incrementing the row counter, and adding each to a new row.

If the user then specifies a row, appJar starts counting from there, reusing row numbers already used before - this is handy if populating a new column, but breaks things if not.

There are two options here:

  • Leave as is, and update docs to explain situation
  • Change the functionality, so that the empty row counter is not updated, if the new row is less than the specified row.

jarvisteach added a commit that referenced this issue Feb 13, 2018

Updated layout settings #301
RCS can now include `previous` and `next`
Moved parsePos to add section of simpleNamers
DatePicker now takes “today” as a param. #175
#235 changes:
Updated buttons to handle 2D list
Added kwargs to tab & panedFrame
Updated showcase to use new features

jarvisteach added a commit that referenced this issue Feb 13, 2018

@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Feb 13, 2018

Decided to go with first option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment