New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility #328

Closed
mpmc opened this Issue Dec 22, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@mpmc
Contributor

mpmc commented Dec 22, 2017

As someone with poor sight, I think it would be awesome to have a built-in accessibility widget. Perhaps a simple icon, that launches a small window that displays text size and font options?

@jarvisteach jarvisteach added this to the 1.1 milestone Dec 23, 2017

@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Jan 5, 2018

I do like this idea - I'm thinking another dialog with some options to change the GUI:

  • font size
  • font family
  • fg colour
  • bg colour

And, perhaps, an advanced option, which lists widgets and allows you to change them independently...

jarvisteach added a commit that referenced this issue Feb 13, 2018

Playing with issue #328
Pop-up for configuring GUI settings.

Fixed a couple of issues (#235, #340):
* getFonts was returning None, now works & has property
* subWindow can take kwargs
* checkBox simple setter wasn’t working
* optionBox simple setter now takes a selected param
* tip param introduced
* buttons simple setter introduced
@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Feb 13, 2018

Have done a bit of a proof of concept on this (see the code committed above).

Really pleased with how the code looks - made a lot of use of new functions & properties. Less than 40 lines to produce this:

accessibility

Works reasonably well. Identified a couple of issues:

  • would be useful to have .getBg() function #373
  • struggled to get padding how I wanted it, without resorting to tkinter
  • would be useful to be able to propagate settings through containers...

jarvisteach added a commit that referenced this issue Feb 13, 2018

getXXXBg() Function #373
Added new function for getting the BG of a widget, and use it in
accessibility #328
@mpmc

This comment has been minimized.

Contributor

mpmc commented Feb 13, 2018

This looks awesome, few comments.

  • Don't forget tooltips!
  • I would replace Update and close buttons with "Reset" (on the far left?), "OK", "Cancel".
  • Allow access to the window via any widget, not just via an icon.

jarvisteach added a commit that referenced this issue Feb 13, 2018

Updates to #328
Added tooltips, reset button, and loading of current settings

Also, moved `getXXXBg()` to use `getWidgetProperty()` #373

jarvisteach added a commit that referenced this issue Feb 14, 2018

Added accessibility widget #328
New function for testing - showAccess.

Some changes to be made, as widget names might clash with user widget
names.

Hopefully, will work with removeAllWidgets()!

jarvisteach added a commit that referenced this issue Feb 14, 2018

Update #328
Most widget names now better.

labelFrame now has a name parameter…

jarvisteach added a commit that referenced this issue Feb 14, 2018

Update to MAKE_FUNC
MAKE_FUNC now handles class functions #335
Renamed access widget buttons #328

@jarvisteach jarvisteach referenced this issue Feb 14, 2018

Closed

Configure properties for gui settings #340

39 of 39 tasks complete

@jarvisteach jarvisteach modified the milestones: 1.1, 1.0 Feb 15, 2018

jarvisteach added a commit that referenced this issue Feb 16, 2018

New properties, updated testing #340
Getters for:
* padding
* guiPadding
* inPadding
* transparency
* editMenu

Accessibility now use above getter #328

Refactored setSize - simplified

Updated testing
@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Feb 16, 2018

OK, this is in and working.

Will probably need tweaking, but going to close this issue.

jarvisteach added a commit that referenced this issue Feb 16, 2018

jarvisteach added a commit that referenced this issue Feb 17, 2018

Updated to access #328
Added accessibility to showcase
Changed access original font variable names
Introduced dedicated font for access.
Updated setFont for widgets to allow font classes.

jarvisteach added a commit that referenced this issue Feb 17, 2018

Updated to labelled widgets #377
_getLabelBox now sets a label & font if they’re provided

Labelled widgets updated to pass label parameter

Access #328 updated to take advantage of this

jarvisteach added a commit that referenced this issue Feb 17, 2018

Updates to fonts
Standardised fonts as:
_outputFont, _inputFont & _buttonFont

Still a couple to work out.

Added label to checkBox #377
Added font selectors to access #328
PagedWindow now uses global fonts

jarvisteach added a commit that referenced this issue Feb 17, 2018

Font objects accepted #385
Toolbar now uses buttonFont
linkFont clash fixed
Renamed outputFont to labelFont

Updated access to reset font checks #328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment