New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

favicon.ico not defined #343

Closed
rockstar8577 opened this Issue Jan 9, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@rockstar8577

rockstar8577 commented Jan 9, 2018

I'm having issues with packing my script into an exe with pyinstaller. If I do a simple script it packs fine. However if I move to a more advanced script with more multiple windows and such it has an issue with

Traceback (most recent call last):
  File "Bot.py", line 70, in <module>
  File "site-packages\appJar\appjar.py", line 4471, in startSubWindow
  File "site-packages\appJar\appjar.py", line 2444, in setIcon
  File "tkinter\__init__.py", line 1865, in wm_iconbitmap
_tkinter.TclError: bitmap "C:\Users\Josh\Desktop\Python\sandbox\dist\Bot\appJar\resources\icons\favicon.ico" not defined
[7488] Failed to execute script Bot

Now i've tried getting around this by including the appJar folder into my exe location. This does get it to start, but only for a debug build with pyinstaller. If i package it into a self-contained exe it just doesn't run and gives a message of "failed to execute script". Not sure how to get it to stop using the icon for the subwindow.

@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Jan 9, 2018

By default, on Windows - appJar uses it's own icon for all windows.

To stop it using the icon, you can set it to None: app.winIcon = None straight after you create the gui object.

That should prevent subWindws from having an icon. But you might still have issues with the main window having an icon...

Let me know how you get on.

@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Jan 9, 2018

I'll also include an option in the next release to turn off icons when appJar is created.

jarvisteach added a commit that referenced this issue Jan 9, 2018

Added flag to not include icons
Changed `.removeAllWidgets()` to not  remove all items from
WidgetManager - menus, accelerators, toolbars, images, etc are left in
now #339 & #305

Also added additional constructor flag, to prevent adding a favicon #343

@jarvisteach jarvisteach added this to the 0.90 milestone Jan 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment