New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change label creation #344

Closed
jarvisteach opened this Issue Jan 9, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@jarvisteach
Owner

jarvisteach commented Jan 9, 2018

Currently, when a label is created the text parameter defaults to None.

If it is None the label is populated with an empty string.

I'd like to change this. Instead, if None is passed (or no argument is passed) then I'd like the label to be populated with its title. If the user wants an empty string, they should pass an empty string ""

This will allow for slightly simpler label creation - when the user has no intention of interacting with labels in the future, the title is redundant, so they only need to provide a single argument - it will be used as the title and text.

This is a change in behaviour, so may negatively impact some existing apps, so I will include a warning message in the .addLabel() function until the 1.0 release, if the text parameter is None.

@jarvisteach jarvisteach added this to the 0.90 milestone Jan 9, 2018

jarvisteach added a commit that referenced this issue Jan 9, 2018

update to label creation #344
Labels with `None` text now display the title instead of an empty
string.

@jarvisteach jarvisteach closed this Jan 9, 2018

jarvisteach added a commit that referenced this issue Jan 12, 2018

Updates to addMessage #344
addMessage can now work with a single parameter, the message text and
title will be the same.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment