New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions to raise/lower frames #345

Closed
jarvisteach opened this Issue Jan 9, 2018 · 5 comments

Comments

Projects
None yet
1 participant
@jarvisteach
Owner

jarvisteach commented Jan 9, 2018

Currently appJar relies on hiding/removing widgets for its custom containers, as well as for users to create different screens.

An alternative & smoother approach is to have multiple frames all in the same grid cell, and to raise the current one above the others.

That results in not having to constantly forget & regrid widgets.

The current containers could be re-written to use this approach, and new functions could be implemented to allow users to easily manage multiple frames and raise/lower them as required.

@jarvisteach jarvisteach added this to the 1.0 milestone Jan 9, 2018

jarvisteach added a commit that referenced this issue Mar 3, 2018

@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Mar 3, 2018

Works well - uses the .lift() function on a Frame object.

Could be used on PagedWindow & TabbedFrame.

Could introduce a new grouped widget - FrameSet - that provides previous/next/first/last/goto (pos/name)

jarvisteach added a commit that referenced this issue Mar 3, 2018

jarvisteach added a commit that referenced this issue Mar 3, 2018

New Container FrameStack #345
Introduced new containers `FrameStack` & `SubFrame`. Allows user to
have multiple frames on top of each other, and navigate through them by
number:
* nextSubFrame
* prevSubFrame
* firstSubFrame
* lastSubFrame
* selectSubFrame(pos)
@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Mar 3, 2018

New container introduced - provides lots of the features of the PagedWindow...

Should add names for each frame and ability to select by name...

jarvisteach added a commit that referenced this issue Mar 3, 2018

@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Mar 4, 2018

Have been thinking about this some more.

  • SubFrames should just be Frames - when it is added, it determines if it's in a FrameSet or not, and does the right thing.
  • FrameSets can also be frames, with a flag set on them...

jarvisteach added a commit that referenced this issue Apr 9, 2018

Updates to FrameSets #345
Renamed FrameSet to FrameStack
SubFrames are now just Frames.
Updated docs.

Updated versioning to 0.93
@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Apr 9, 2018

SubFrames are now just Frames. FrameSets renamed to FrameStacks.

jarvisteach added a commit that referenced this issue Apr 9, 2018

Updates to FrameStack #345
* Introduced changeFunction, and associated callFunction parameters.
* Introduced start frame.
* Functions to get current & previous, and ability to return false from
changeFunction to cancel changing frame.

jarvisteach added a commit that referenced this issue Apr 9, 2018

FrameStack Testing #345
Implemented testing for FrameStacks
@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Apr 9, 2018

This is working now - will raise separate issues for migrating other containers.

@jarvisteach jarvisteach closed this Apr 9, 2018

jarvisteach added a commit that referenced this issue Apr 10, 2018

Fixed bug in FrameStack #345
Setting a stat frame was breaking the stack

jarvisteach added a commit that referenced this issue Apr 12, 2018

Investigating #432
Also, documented  & tested `raiseFrame` added in #345

jarvisteach added a commit that referenced this issue Apr 13, 2018

new functions to check if at start/end in framestack #345, and update…
… to validation entry, to cast all to string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment