New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopping the GUI can be slow #395

Closed
jarvisteach opened this Issue Mar 1, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@jarvisteach
Owner

jarvisteach commented Mar 1, 2018

Calling stop can be slow when there are a lot of widgets.

For example, a grid with hundreds of rows can take 10-20 seconds to shutdown.

This is because stop calls destroy() on the topLevel - and it has to loop through and destroy each of the widgets.

Ideally we want destroy to be called, but should give the user the option to skip it if they want.

Should introduce a flag to skip .destroy() if desired.

@jarvisteach jarvisteach added this to the 1.0 milestone Mar 1, 2018

jarvisteach added a commit that referenced this issue Mar 1, 2018

Grid updates
Improved performance of Grid #266
* moved some calculations outside of loops
* changed some loops to use map or list comprehension
* used join instead of string concatenation

Changed how DB grids get data - now instead of generating a list, and
passing the list as a param, it passes the cursor, and grid loops
through that.

New option to disabled entry boxes - pass in an array of positions to
disable, or call new function `.disableTableEntry()`

Also, new option to stop GUIs without destroying widgets #395
@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Mar 2, 2018

Having a parameter to the stop function is not ideal - it doesn't get used if the X is clicked, etc.

So instead, will introduce a GUI property to determine if we fast stop or not...

jarvisteach added a commit that referenced this issue Mar 2, 2018

@jarvisteach

This comment has been minimized.

Owner

jarvisteach commented Mar 2, 2018

This breaks appJar from IDLE - calling quit() on its own won't stop the GUI, it has to be destroyed.

jarvisteach added a commit that referenced this issue Mar 2, 2018

Updated docs #395
Also fixed issue with status bar & testing #235

@jarvisteach jarvisteach closed this Mar 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment