New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No setFg function #7

Closed
jarvisteach opened this Issue May 20, 2016 · 2 comments

Comments

Projects
None yet
1 participant
@jarvisteach
Owner

jarvisteach commented May 20, 2016

Users expect a setFg function, to operate in same way as setBg...

@jarvisteach

This comment has been minimized.

Show comment
Hide comment
@jarvisteach

jarvisteach Aug 12, 2016

Owner

Need to consider:

  • Object creation - initial FG either default or inherited from container
  • set XXX Fg - calling a set FG for a specific widget. If container, propagate
  • setFg - calling this should affect all widgets in GUI that are created, and be picked up by any new widgets aded

Three helper functions:

  • .__positionWidget() - calls __setWidgetBg() with container's BG, should also update FG?
  • .__widgetIsContainer() - checks if a widget is a container
  • .__setWidgetBg() - different things for different widget types...
Owner

jarvisteach commented Aug 12, 2016

Need to consider:

  • Object creation - initial FG either default or inherited from container
  • set XXX Fg - calling a set FG for a specific widget. If container, propagate
  • setFg - calling this should affect all widgets in GUI that are created, and be picked up by any new widgets aded

Three helper functions:

  • .__positionWidget() - calls __setWidgetBg() with container's BG, should also update FG?
  • .__widgetIsContainer() - checks if a widget is a container
  • .__setWidgetBg() - different things for different widget types...
@jarvisteach

This comment has been minimized.

Show comment
Hide comment
@jarvisteach

jarvisteach Aug 12, 2016

Owner

Problem is, a lot of containers don't have an FG property - so we can't inherit from them

Instead, we'll start with an initial FG colour of black, and store it as a container property - then object creation can inherit from container.

Owner

jarvisteach commented Aug 12, 2016

Problem is, a lot of containers don't have an FG property - so we can't inherit from them

Instead, we'll start with an initial FG colour of black, and store it as a container property - then object creation can inherit from container.

jarvisteach pushed a commit that referenced this issue Aug 18, 2016

Richard Jarvis
Start Grid Rewrite (#51) & setFG (#7)
Moved Grid into its own widget class, so removed some bits from main
GUI class
Two functions for grids currently: addGrid & getGridEntries

Started setFg:
* SET_WIDGET_FONT
* __getContainerFont

@jarvisteach jarvisteach modified the milestone: 0.06 Feb 25, 2017

@jarvisteach jarvisteach modified the milestones: 0.06, 0.061, 0.07 Apr 13, 2017

@jarvisteach jarvisteach modified the milestones: 0.08, 0.07 May 29, 2017

jarvisteach added a commit that referenced this issue Jul 22, 2017

Issue #7
Test setFg code
Change to border on TabbedFrame

jarvisteach added a commit that referenced this issue Jul 22, 2017

jarvisteach added a commit that referenced this issue Jul 25, 2017

Test for setBg/Fg #7
Adds most widgets allows FG/BG to be set

jarvisteach added a commit that referenced this issue Jul 25, 2017

Changes to setFg/Bg #7
Update to setting FG/BG:
* Lots of changes to SET_WIDGET_FG/BG
* SET_WIDGET_FG now static
* New class - `ParentBox' to provide inherited config & constructor. This is then extended from with LabelBox, ButtonBox & WidgetBox
* Containers now return themselves when started.

jarvisteach added a commit that referenced this issue Jul 25, 2017

jarvisteach added a commit that referenced this issue Jul 25, 2017

jarvisteach added a commit that referenced this issue Jul 27, 2017

jarvisteach added a commit that referenced this issue Jul 28, 2017

jarvisteach added a commit that referenced this issue Jul 28, 2017

jarvisteach added a commit that referenced this issue Jul 28, 2017

jarvisteach pushed a commit that referenced this issue Jul 29, 2017

Richard Jarvis

jarvisteach added a commit that referenced this issue Jul 29, 2017

More work on BG/FG #7
TINT now returns system default, if too close to 255

AutoCompleteEntry now colours listbox

Reordered SET_WIDGET_BG

jarvisteach added a commit that referenced this issue Jul 31, 2017

Ensure flash labels stay correct #7
Keep a copy of original FG/BG in flash label, that way if they are
changed, the flash label will keep the right combination

Also, made TINT user configurable, with additional parameter to setBg

jarvisteach added a commit that referenced this issue Aug 1, 2017

Update to FG/BG #7
Updated documentation
setFg now updates links appropriately.

@jarvisteach jarvisteach modified the milestones: 0.07, 0.08 Aug 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment