Added Labeled Auto Entry #109

Merged
merged 3 commits into from Mar 11, 2017

Conversation

Projects
None yet
3 participants
@jacobthetechy
Contributor

jacobthetechy commented Mar 10, 2017

Hey thinking this should be a thing.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 10, 2017

Coverage Status

Coverage decreased (-0.05%) to 68.391% when pulling 50b47db on jacobthetechy:next_release into 2ebd6c7 on jarvisteach:next_release.

coveralls commented Mar 10, 2017

Coverage Status

Coverage decreased (-0.05%) to 68.391% when pulling 50b47db on jacobthetechy:next_release into 2ebd6c7 on jarvisteach:next_release.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 10, 2017

Coverage Status

Coverage decreased (-0.05%) to 68.391% when pulling 50b47db on jacobthetechy:next_release into 2ebd6c7 on jarvisteach:next_release.

Coverage Status

Coverage decreased (-0.05%) to 68.391% when pulling 50b47db on jacobthetechy:next_release into 2ebd6c7 on jarvisteach:next_release.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 10, 2017

Coverage Status

Coverage decreased (-0.05%) to 68.391% when pulling 50b47db on jacobthetechy:next_release into 2ebd6c7 on jarvisteach:next_release.

Coverage Status

Coverage decreased (-0.05%) to 68.391% when pulling 50b47db on jacobthetechy:next_release into 2ebd6c7 on jarvisteach:next_release.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 10, 2017

Coverage Status

Coverage decreased (-0.05%) to 68.391% when pulling 50b47db on jacobthetechy:next_release into 2ebd6c7 on jarvisteach:next_release.

Coverage Status

Coverage decreased (-0.05%) to 68.391% when pulling 50b47db on jacobthetechy:next_release into 2ebd6c7 on jarvisteach:next_release.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 10, 2017

Coverage Status

Coverage decreased (-0.05%) to 68.391% when pulling 50b47db on jacobthetechy:next_release into 2ebd6c7 on jarvisteach:next_release.

Coverage Status

Coverage decreased (-0.05%) to 68.391% when pulling 50b47db on jacobthetechy:next_release into 2ebd6c7 on jarvisteach:next_release.

@jarvisteach

This comment has been minimized.

Show comment
Hide comment
@jarvisteach

jarvisteach Mar 11, 2017

Owner

This is great - I'm happy to receive additions to the library!!!

But, I'd love for you to include it in the test suite as well - to stop coveralls from complaining!

I've found it tough getting test coverage for everything, because a lot of it is event driven, but I'm slowly getting there. At a minimum, I like to make sure every widget has been added to the test gui

So, in this case, can you add a line to tests/widget_test.py in the function test_auto_labels() that just adds a labelAutoEntry. That will ensure the function is called by the test suite, and ensure basic syntax errors aren't introduced.

You can go further if you want, and include it in the test_entries() function - but, as it's reusing already tested components, that shouldn't be necessary...

And, if you're feeling really adventurous, you could update the documentation too!
This will require an extra line in the list of auto labelled widgets in docs/mkdocs/docs/pythonWidgets.md, although I'm happy to do that...

Exciting times!

Owner

jarvisteach commented Mar 11, 2017

This is great - I'm happy to receive additions to the library!!!

But, I'd love for you to include it in the test suite as well - to stop coveralls from complaining!

I've found it tough getting test coverage for everything, because a lot of it is event driven, but I'm slowly getting there. At a minimum, I like to make sure every widget has been added to the test gui

So, in this case, can you add a line to tests/widget_test.py in the function test_auto_labels() that just adds a labelAutoEntry. That will ensure the function is called by the test suite, and ensure basic syntax errors aren't introduced.

You can go further if you want, and include it in the test_entries() function - but, as it's reusing already tested components, that shouldn't be necessary...

And, if you're feeling really adventurous, you could update the documentation too!
This will require an extra line in the list of auto labelled widgets in docs/mkdocs/docs/pythonWidgets.md, although I'm happy to do that...

Exciting times!

Jacob added some commits Mar 11, 2017

@jacobthetechy

This comment has been minimized.

Show comment
Hide comment
@jacobthetechy

jacobthetechy Mar 11, 2017

Contributor

How does that look?

Contributor

jacobthetechy commented Mar 11, 2017

How does that look?

@jarvisteach jarvisteach merged commit abab285 into jarvisteach:next_release Mar 11, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
code-quality/landscape Landscape has completed the code quality check
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jarvisteach jarvisteach self-requested a review Mar 11, 2017

@jarvisteach jarvisteach added this to the 0.05 milestone Mar 11, 2017

@jacobthetechy jacobthetechy deleted the jacobthetechy:next_release branch Mar 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment