Permalink
Browse files

Backbone 0.9.9

  • Loading branch information...
1 parent 87a25d5 commit 18b445e8a0eaf438dd244121e24a2a6041c62052 @jashkenas committed Dec 13, 2012
Showing with 912 additions and 653 deletions.
  1. +37 −35 backbone-min.js
  2. +2 −8 backbone.js
  3. +69 −27 docs/backbone-localstorage.html
  4. +519 −454 docs/backbone.html
  5. +7 −1 docs/docco.css
  6. +36 −35 docs/todos.html
  7. +241 −92 index.html
  8. +1 −1 package.json
View

Large diffs are not rendered by default.

Oops, something went wrong.
View
@@ -1,4 +1,4 @@
-// Backbone.js 0.9.9-pre
+// Backbone.js 0.9.9
// (c) 2010-2012 Jeremy Ashkenas, DocumentCloud Inc.
// Backbone may be freely distributed under the MIT license.
@@ -34,7 +34,7 @@
}
// Current version of the library. Keep in sync with `package.json`.
- Backbone.VERSION = '0.9.9-pre';
+ Backbone.VERSION = '0.9.9';
// Require Underscore, if we're on the server, and it's not already present.
var _ = root._;
@@ -566,12 +566,6 @@
return _.clone(this._previousAttributes);
},
- // Check if the model is currently in a valid state. It's only possible to
- // get into an *invalid* state if you're using silent changes.
- isValid: function(options) {
- return !this.validate || !this.validate(this.attributes, options);
- },
-
// Run validation against the next complete set of model attributes,
// returning `true` if all is well. If a specific `error` callback has
// been passed, call that instead of firing the general `"error"` event.

Large diffs are not rendered by default.

Oops, something went wrong.
View

Large diffs are not rendered by default.

Oops, something went wrong.
View
@@ -21,6 +21,12 @@ h1, h2, h3, h4, h5, h6 {
h1 {
margin-top: 40px;
}
+hr {
+ border: 0 none;
+ border-top: 1px solid #e5e5ee;
+ height: 1px;
+ margin: 20px 0;
+}
#container {
position: relative;
}
@@ -115,7 +121,7 @@ table td {
}
pre, tt, code {
font-size: 12px; line-height: 18px;
- font-family: Monaco, Consolas, "Lucida Console", monospace;
+ font-family: Menlo, Monaco, Consolas, "Lucida Console", monospace;
margin: 0; padding: 0;
}
View

Large diffs are not rendered by default.

Oops, something went wrong.
View

Large diffs are not rendered by default.

Oops, something went wrong.
View
@@ -14,5 +14,5 @@
"test": "phantomjs test/vendor/runner.js test/index.html"
},
"main" : "backbone.js",
- "version" : "0.9.9-pre"
+ "version" : "0.9.9"
@jed

jed Dec 14, 2012

Contributor

i think this should really be 0.10.0, given that there are breaking changes. would love to see better semver hygiene from backbone in the future.

@jashkenas

jashkenas Dec 14, 2012

Owner

I'm afraid that technically speaking, the semantic versioning is still correct. Quoth http://semver.org:

Patch version Z (x.y.Z | x > 0) MUST be incremented if only backwards compatible bug fixes are
introduced. A bug fix is defined as an internal change that fixes incorrect behavior.

... the rules only apply if the codebase is greater than 1.0. In fact, if you read further:

Major version X (X.y.z | X > 0) MUST be incremented if any backwards incompatible changes
are introduced to the public API. It MAY include minor and patch level changes. Patch and
minor version MUST be reset to 0 when major version is incremented.

That said, I also find semantic versioning a pretty hard idea to get behind. Any change worthy of the name breaks backward compatibility in some small way -- even if just for a single edge case, for a single user. I'd be hard pressed to remember a Backbone version bump that didn't change behavior or add features in one minor way or another. So if we followed the spirit of the law of semver.org, Backbone would be at version 16.0. I'd rather use the version number to convey the relative magnitude of the change -- and the "Upgrading" section of the docs to convey the specific things you'll want to know in order to upgrade.

}

0 comments on commit 18b445e

Please sign in to comment.