Skip to content
This repository

The site backbone.js version is missing validation in save() #1906

j-unior opened this Issue December 12, 2012 · 1 comment

2 participants

Yevgenij Jeremy Ashkenas

Hi guys,
I've been breaking my head for a while, why invalid models are persisted to server, and today looked at github version of backbone.js. What I've noticed is that in the site ( version the following lines in save method:

  // Do not persist invalid models.
  if (!attrs && !this.isValid()) return false;

are missing!!!
It doesn't seem OK to me, isn't it?

Jeremy Ashkenas

Yes it is -- feel free to use master in the meantime.

Jeremy Ashkenas jashkenas closed this December 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.