Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset fires a change event even if it isn't an attribute on the object #209

Closed
shaug opened this issue Feb 2, 2011 · 2 comments
Closed

Comments

@shaug
Copy link

shaug commented Feb 2, 2011

Successive calls to unset for an attribute on a model, without setting the atrribute's value between calls, will fire change events for each unset call, even though nothing has changed.

It makes sense that unset would follow set's behavior when triggering change calls; that they're only fired when the previous value for the attribute differs from the current one.

@jashkenas
Copy link
Owner

Thanks for the note -- I've taken a stab at fixing the issue here: b86d3f6, with a test.

@shaug
Copy link
Author

shaug commented Feb 7, 2011

Looks like the right fix to me. Thanks!

jasonwebster pushed a commit to jasonwebster/backbone that referenced this issue May 13, 2011
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants