Add favicon to backbonejs.org #2883

Closed
dminkovsky opened this Issue Nov 19, 2013 · 6 comments

Projects

None yet

4 participants

@dminkovsky

I use Chrome's "pin tab" feature, which makes things look like this:

Screenshot

One of the tabs in there is http://backbonejs.org/docs/backbone.html, but I can't tell which unless I remember.

Is there a favicon we can use for http://backbonejs.org/docs/backbone.html?

@akre54
Collaborator
akre54 commented Nov 19, 2013

Good catch. The docs page is generated by docco, which as far as I can tell doesn't accept a custom favicon without using a custom template. Might be worth adding as a feature.

@akre54
Collaborator
akre54 commented Nov 19, 2013

So it does :)

That's because underscore.org has the favicon.ico file in the domain root, but in Backbone it's in a subdir. The behavior is deprecated and it's a little cleaner to put it with the rest of the docs assets, but I don't see any harm in moving it to the root. Any objections from anyone?

edit: @dminkovsky pointed out that the favicon shows up on underscore.org's annotated docs.

@braddunbar
Collaborator

👍 for moving it to the root.

@akre54 akre54 closed this Nov 19, 2013
@dminkovsky

Thanks very much.

@mikecapp

Should favicon.ico be added to bower.js' ignore list, now that it's no longer covered by the "docs" entry?

@akre54
Collaborator
akre54 commented Jan 28, 2014

Good call. 8429118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment