Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.2.4 #3839

Closed
jridgewell opened this issue Oct 27, 2015 · 14 comments
Closed

v1.2.4 #3839

jridgewell opened this issue Oct 27, 2015 · 14 comments

Comments

@jridgewell
Copy link
Collaborator

@jridgewell jridgewell commented Oct 27, 2015

Features

  • Use _.create in .extend #3553
  • Add #findIndex and #findLastIndex to Collection #3811

Bug Fixes

  • #_removeModels model still in collection regression #3803
  • #set model id regression #3833
  • #remove returning false regression #3837
  • #reduce and friends regression #3820

Maybe

  • Deopt Underscore methods containing arguments #3840
  • Add #preinitialize #3827
  • Add update event feedback #3711
  • Object.prototype conflicts with _.defaults #3843

/cc @paulfalgout. 😄

@akre54

This comment has been minimized.

Copy link
Collaborator

@akre54 akre54 commented Oct 28, 2015

Well Jeremy is currently taking on the Americas on his bike, so I believe the decision falls to @braddunbar on how and when to cut a release.

#3827 and #3820 #3840 are pretty ugly hacks. Are you sure they're necessary?

@jridgewell

This comment has been minimized.

Copy link
Collaborator Author

@jridgewell jridgewell commented Oct 28, 2015

I scaled #3820 back to just deopting #reduce, not the arguments check that's now in #3840. The arguments check isn't necessary.


As for #3827, I think it should go out with this release, since I don't imagine any more v1 releases (I'd rather start merging v2 PRs). Non-breaking, generic, and people can choose to incorporate ES6 without redoing the entire app for v2.

I think it's pretty good solution... Do you have a particular objection to it?

@akre54

This comment has been minimized.

Copy link
Collaborator

@akre54 akre54 commented Oct 28, 2015

The arguments check isn't necessary.

Right, I was referring to pre-split. I'm still not a fan of #3840.

I'd rather start merging v2 PRs

What've you got in mind for v2? A complete overhaul? Something more gradual?

I think it's pretty good solution... Do you have a particular objection to it?

(Responding there for clarity)

@jridgewell

This comment has been minimized.

Copy link
Collaborator Author

@jridgewell jridgewell commented Oct 29, 2015

Adding #3842 as a needed bugfix.

@paulfalgout

This comment has been minimized.

Copy link
Collaborator

@paulfalgout paulfalgout commented Dec 2, 2015

updates?

@jdalton

This comment has been minimized.

Copy link
Contributor

@jdalton jdalton commented Dec 15, 2015

For the remaining new features of

Add #preinitialize #3827
Add update event feedback #3711

I think they can be cut unless there are PRs ready to merge.
It looks like there's a PR for #3711 but it has fallen idle with merge conflicts.

@jridgewell

This comment has been minimized.

Copy link
Collaborator Author

@jridgewell jridgewell commented Dec 16, 2015

Agreed, I think this is ready to go.

@megawac

This comment has been minimized.

Copy link
Collaborator

@megawac megawac commented Dec 21, 2015

Anyone want to draft up a pull request with changelog/documentation updates?

@jdalton

This comment has been minimized.

Copy link
Contributor

@jdalton jdalton commented Jan 6, 2016

Ping? @braddunbar

If not I'll try to get a PR out tonight.

@jridgewell

This comment has been minimized.

Copy link
Collaborator Author

@jridgewell jridgewell commented Jan 6, 2016

It's usually @paulfalgout. 😄

@jdalton

This comment has been minimized.

Copy link
Contributor

@jdalton jdalton commented Jan 6, 2016

First one with the PR wins!

@paulfalgout

This comment has been minimized.

Copy link
Collaborator

@paulfalgout paulfalgout commented Jan 6, 2016

ha! Yeah @jdalton take it if you're up for it. I am a bit snowed under this week. If you don't get around to it, I'll jump in later.

@jdalton

This comment has been minimized.

Copy link
Contributor

@jdalton jdalton commented Jan 9, 2016

Draft changelog at #3921.

@jridgewell

This comment has been minimized.

Copy link
Collaborator Author

@jridgewell jridgewell commented Jan 11, 2016

Closing with #3921.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.