Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection.set behavior changed in 1.2.3 #3871

Closed
Flamefork opened this issue Nov 27, 2015 · 2 comments
Closed

Collection.set behavior changed in 1.2.3 #3871

Flamefork opened this issue Nov 27, 2015 · 2 comments
Labels
question

Comments

@Flamefork
Copy link
Contributor

This change a082d2f#diff-0d56d0d310de7ff18b3cef9c2f8f75dcR797
changes the behavior if collection's parse method return falsy value.

Before: empty collection
After: collection with 1 "blank" model

Is it and intended change? My personal consideration is that having 1 empty model in this case is unexpected and unwanted behavior.
@Flamefork Flamefork changed the title Collection.set behavior change in 1.2.3 Collection.set behavior changed in 1.2.3 Nov 29, 2015
@jashkenas
Copy link
Owner

Good question!

@jridgewell
Copy link
Collaborator

Looks like an oversight on my part. Want to work up the PR?

@Flamefork Flamefork mentioned this issue Dec 1, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jashkenas @Flamefork @jridgewell